Skip to content

doc: add missing link for 10.3.0 changelog - #21017

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:v10.3.0-missing-link
Closed

doc: add missing link for 10.3.0 changelog#21017
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:v10.3.0-missing-link

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented May 29, 2018

Copy link
Copy Markdown
Contributor

please fastrack

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 29, 2018
@MylesBorinsMylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label May 29, 2018
@mmarchini

mmarchini commented May 29, 2018

Copy link
Copy Markdown
Contributor

👍 on fast-tracking

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2018
@BridgeAR

BridgeAR commented May 29, 2018

Copy link
Copy Markdown
Member

A CI should not be necessary in this case.

@MylesBorins

MylesBorins commented May 30, 2018

Copy link
Copy Markdown
ContributorAuthor

landed in 8976c79

MylesBorins added a commit that referenced this pull request May 30, 2018
@MylesBorins
doc: add missing link for 10.3.0 changelog
8976c79
PR-URL: #21017
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax pushed a commit that referenced this pull request May 31, 2018
@MylesBorins@addaleax
doc: add missing link for 10.3.0 changelog
c2ae93d
PR-URL: #21017
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jun 6, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+3 more reviewers
@danbevdanbevdanbev approved these changes
@maclover7maclover7maclover7 approved these changes
@mmarchinimmarchinimmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@MylesBorins@mmarchini@BridgeAR@danbev@jasnell@lpinca@maclover7@joyeecheung@trivikr@nodejs-github-bot