Uh oh!
There was an error while loading. Please reload this page.
test: fix flaky test-domain-timers - #21019
Closed
apapirovski wants to merge 1 commit into
Closed
Conversation
It's possible for this test to be extremely infrequently flaky if 1ms or more elapses between setting the two timeouts. In that case, the second timer will not fire and the test will fail.
BridgeAR
approved these changes
May 29, 2018
trivikr
approved these changes
May 29, 2018
jasnell
approved these changes
May 29, 2018
starkwang
approved these changes
May 30, 2018
starkwang
commented
May 30, 2018
Contributor
danbev
approved these changes
May 30, 2018
Trott
commented
May 31, 2018
Member
Re-running osx: https://ci.nodejs.org/job/node-test-commit-osx/18958/ |
apapirovski
commented
Jun 1, 2018
ContributorAuthor
Landed in 4b8ff3a |
apapirovski added a commit
that referenced
this pull request
Jun 1, 2018
It's possible for this test to be extremely infrequently flaky if 1ms or more elapses between setting the two timeouts. In that case, the second timer will not fire and the test will fail. PR-URL: #21019 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Jun 1, 2018
It's possible for this test to be extremely infrequently flaky if 1ms or more elapses between setting the two timeouts. In that case, the second timer will not fire and the test will fail. PR-URL: #21019 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible for this test to be (extremely infrequently) flaky if 1ms (which due to rounding in libuv could be far less, actually) or more elapses between setting the two timeouts. In that case, the second timer will not fire and the test will fail.
This failed recently in https://ci.nodejs.org/job/node-test-commit-linuxone/1701/nodes=rhel72-s390x/testReport/junit/(root)/test/parallel_test_domain_timers/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes