Uh oh!
There was an error while loading. Please reload this page.
docs: fix HTTP req/res 'close' description - #21047
Closed
ronag wants to merge 1 commit into
Closed
Conversation
trivikr
commented
Jun 4, 2018
Member
cc @nodejs/http |
jasnell
approved these changes
Jun 9, 2018
targos
commented
Jun 24, 2018
Member
trivikr
commented
Jun 24, 2018
Member
Landed in 8ab7ea6 |
trivikr pushed a commit
that referenced
this pull request
Jun 24, 2018
PR-URL: #21047 Reviewed-By: James M Snell <jasnell@gmail.com>
devsnek
commented
Jun 24, 2018
Member
this should have had one more approval right? (not saying it needs to be reverted or anything) |
vsemozhetbyt
commented
Jun 24, 2018
Contributor
https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#step-10-landing |
vsemozhetbyt
commented
Jun 24, 2018
Contributor
We need 2 approval for fast-track though (not this case):
https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#waiting-for-approvals |
targos pushed a commit
that referenced
this pull request
Jun 24, 2018
PR-URL: #21047 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist