Uh oh!
There was an error while loading. Please reload this page.
net: use object destructoring for errors - #21050
Closed
danbev wants to merge 1 commit into
Closed
Conversation
danbev
commented
May 31, 2018
ContributorAuthor
trivikr
approved these changes
May 31, 2018
tniessen
approved these changes
May 31, 2018
tniessen
commented
May 31, 2018
Member
Node.js collaborators, please 👍 here to approve fast-tracking. |
jasnell
approved these changes
May 31, 2018
starkwang
commented
Jun 1, 2018
Contributor
This change may be duplicated with #20959. |
apapirovski
commented
Jun 1, 2018
Contributor
danbev
commented
Jun 1, 2018
ContributorAuthor
@apapirovski Perfect, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes