Uh oh!
There was an error while loading. Please reload this page.
Removed extra requires - #21069
Closed
ErnestoSalazar wants to merge 2 commits into
Closed
Conversation
BridgeAR
commented
May 31, 2018
Member
jasnell
approved these changes
May 31, 2018
kfarnung
approved these changes
Jun 1, 2018
trivikr
approved these changes
Jun 1, 2018
Trott
commented
Jun 1, 2018
Member
danbev
approved these changes
Jun 1, 2018
Trott
commented
Jun 1, 2018
Member
Lone CI failure is a known flaky test being actively worked on. Here's a re-run: https://ci.nodejs.org/job/node-test-commit-linux-containered/4871/ |
maclover7
approved these changes
Jun 1, 2018
lpinca
approved these changes
Jun 2, 2018
Trott
commented
Jun 3, 2018
Member
linux-containered re-run: https://ci.nodejs.org/job/node-test-commit-linux-containered/4903/ |
ContributorAuthor
so, how should we proceed with this PR? :o |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 6, 2018
PR-URL: nodejs#21069 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 6, 2018
PR-URL: nodejs#21069 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Jun 6, 2018
Member
Landed in d0943bc...1c8f760 Thanks for the contribution! 🎉 |
MylesBorins pushed a commit
that referenced
this pull request
Jun 6, 2018
PR-URL: #21069 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jun 6, 2018
PR-URL: #21069 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes