Skip to content

benchmark: fix "comparisons"' typo - #21085

Closed
hiroppy wants to merge 1 commit into
nodejs:masterfrom
hiroppy:feature/fix-typo
Closed

benchmark: fix "comparisons"' typo#21085
hiroppy wants to merge 1 commit into
nodejs:masterfrom
hiroppy:feature/fix-typo

Conversation

@hiroppy

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@hiroppyhiroppy added the benchmark Issues and PRs related to the benchmark subsystem. label Jun 1, 2018
@benjamingr

Copy link
Copy Markdown
Member

Collaborators please +1 to support fast-tracking this PR.

@benjamingrbenjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 1, 2018
@Trott

Trott commented Jun 1, 2018

Copy link
Copy Markdown
Member

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 1, 2018
@nodejsnodejs deleted a comment from refackJun 1, 2018
hiroppy added a commit that referenced this pull request Jun 1, 2018
PR-URL: #21085
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@hiroppy

Copy link
Copy Markdown
MemberAuthor

Landed in 923f6ac.

@hiroppyhiroppy closed this Jun 1, 2018
@hiroppy
hiroppy deleted the feature/fix-typo branch June 1, 2018 23:09
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
PR-URL: #21085
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Jun 6, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@hiroppy@benjamingr@Trott@lance@lpinca@richardlau