Skip to content

doc: add offboarding doc - #21103

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:offboarding.md
Closed

doc: add offboarding doc#21103
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:offboarding.md

Conversation

@Trott

@TrottTrott commented Jun 2, 2018

Copy link
Copy Markdown
Member

Add minimal document for what to do when a Collaborator moves to
Collaborator Emeritus or leaves the project.

Checklist

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 2, 2018
@Trott

Trott commented Jun 2, 2018

Copy link
Copy Markdown
MemberAuthor

Comment threaddoc/offboarding.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoudl->should

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@richardlau

Copy link
Copy Markdown
Member

Also commit message:
theproject->the project

@Trott

Trott commented Jun 3, 2018

Copy link
Copy Markdown
MemberAuthor

Fixed commit message. Thanks!

@Trott

Trott commented Jun 3, 2018

Copy link
Copy Markdown
MemberAuthor

@vsemozhetbytvsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Jun 3, 2018
Comment threaddoc/offboarding.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but is them a bit confusing here? Maybe a Collaborator or someone etc?

@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 3, 2018
Add minimal document for what to do when a Collaborator moves to
Collaborator Emeritus or leaves the project.
@Trott

Trott commented Jun 3, 2018

Copy link
Copy Markdown
MemberAuthor

@lance

lance commented Jun 4, 2018

Copy link
Copy Markdown
Member

A third lite CI, this time successful: https://ci.nodejs.org/job/node-test-pull-request-lite/805/

@Trott

Trott commented Jun 5, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in fc3fd60

@TrottTrott closed this Jun 5, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jun 5, 2018
Add minimal document for what to do when a Collaborator moves to
Collaborator Emeritus or leaves the project.
PR-URL: nodejs#21103
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
Add minimal document for what to do when a Collaborator moves to
Collaborator Emeritus or leaves the project.
PR-URL: #21103
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@MylesBorinsMylesBorins mentioned this pull request Jun 6, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott@richardlau@lance@lpinca@mmarchini@vsemozhetbyt@trivikr@nodejs-github-bot