Uh oh!
There was an error while loading. Please reload this page.
test: unmark test as flaky - #21109
Closed
apapirovski wants to merge 1 commit into
Closed
Conversation
apapirovski
commented
Jun 3, 2018
ContributorAuthor
Please 👍 if you approve fast-tracking. |
apapirovski
commented
Jun 3, 2018
ContributorAuthor
addaleax
approved these changes
Jun 3, 2018
tniessen
approved these changes
Jun 3, 2018
Trott
approved these changes
Jun 3, 2018
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 3, 2018
PR-URL: nodejs#21109 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
commented
Jun 3, 2018
Member
Landed in d528781 |
MylesBorins pushed a commit
that referenced
this pull request
Jun 6, 2018
PR-URL: #21109 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is no longer flaky as of #21077.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes