Skip to content

src: fix typo string_search.h comment - #21115

Closed
shisama wants to merge 1 commit into
nodejs:masterfrom
shisama:typo-string-search-comment
Closed

src: fix typo string_search.h comment#21115
shisama wants to merge 1 commit into
nodejs:masterfrom
shisama:typo-string-search-comment

Conversation

@shisama

@shisamashisama commented Jun 3, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Jun 3, 2018
@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 3, 2018
@vsemozhetbyt

vsemozhetbyt commented Jun 3, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt

vsemozhetbyt commented Jun 3, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/15244/

@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 3, 2018
@addaleax

addaleax commented Jun 3, 2018

Copy link
Copy Markdown
Member

Landed in 75f6ef9 🎉

Thanks for the PR!

@addaleaxaddaleax closed this Jun 3, 2018
addaleax pushed a commit that referenced this pull request Jun 3, 2018
Masashi Hirano@addaleax
src: fix typo string_search.h comment
75f6ef9
PR-URL: #21115
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
Masashi Hirano@MylesBorins
src: fix typo string_search.h comment
66f4c7b
PR-URL: #21115
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jun 6, 2018
Merged
@snyk-botsnyk-bot mentioned this pull request Mar 18, 2020
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@richardlaurichardlaurichardlau approved these changes
@trivikrtrivikrtrivikr approved these changes
+2 more reviewers
@maclover7maclover7maclover7 approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.bufferIssues and PRs related to the buffer subsystem.c++Issues and PRs that require attention from people who are familiar with C++.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shisama@vsemozhetbyt@addaleax@maclover7@richardlau@trivikr@nodejs-github-bot