Skip to content

test: improve debug output in trace-events test#21120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: improve debug output in trace-events test #21120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/parallel/test-trace-events-fs-sync.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const fs = require('fs');
const util = require('util');

const tests = new Array();
const traceFile = 'node_trace.1.log';
Expand DownExpand Up@@ -118,7 +119,8 @@ for (const tr in tests) {
const proc = cp.spawnSync(process.execPath,
[ '--trace-events-enabled',
'--trace-event-categories', 'node.fs.sync',
'-e', tests[tr] ]);
'-e', tests[tr] ],
{ encoding: 'utf8' });
// Some AIX versions don't support futimes or utimes, so skip.
if (common.isAIX && proc.status !== 0 && tr === 'fs.sync.futimes') {
continue;
Expand All@@ -128,7 +130,7 @@ for (const tr in tests) {
}

// Make sure the operation is successful.
assert.strictEqual(proc.status, 0, tr + ': ' + proc.stderr);
assert.strictEqual(proc.status, 0, `${tr}:\n${util.inspect(proc)}`);

// Confirm that trace log file is created.
assert(common.fileExists(traceFile));
Expand Down