Uh oh!
There was an error while loading. Please reload this page.
test: move benchmark-dgram to sequential - #21144
Closed
apapirovski wants to merge 1 commit into
Closed
Conversation
This test uses hardcoded ports, it should not be located in parallel.
apapirovski
commented
Jun 5, 2018
ContributorAuthor
apapirovski
commented
Jun 5, 2018
ContributorAuthor
Please 👍 here to approve fast-tracking. |
targos
approved these changes
Jun 5, 2018
cjihrig
approved these changes
Jun 5, 2018
joyeecheung
approved these changes
Jun 5, 2018
trivikr
approved these changes
Jun 6, 2018
Trott
reviewed
Jun 6, 2018
| construnBenchmark=require('../common/benchmark'); | ||
| // Because the dgram benchmarks use hardcoded ports, this should be in |
Trott
approved these changes
Jun 6, 2018
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM with or without my nit addressed. +1 to fast-tracking.
Trott
commented
Jun 6, 2018
Member
Landed in d0943bc |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 6, 2018
This test uses hardcoded ports, it should not be located in parallel. PR-URL: nodejs#21144 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jun 6, 2018
This test uses hardcoded ports, it should not be located in parallel. PR-URL: #21144 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test uses hardcoded ports, it should not be located in parallel.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes