Skip to content

tools,gyp: fix regex for version matching - #21216

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-gyp
Closed

tools,gyp: fix regex for version matching#21216
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-gyp

Conversation

@Trott

@TrottTrott commented Jun 8, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

Refs: nodejs/node-gyp@293092c

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
tools,gyp: fix regex for version matching
44849eb
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
Refs: nodejs/node-gyp@293092c
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Jun 8, 2018
@TrottTrott changed the title tools: fix gyp regular expression version matchingtools,gyp: fix regex for version matchingJun 8, 2018
@Trott

Trott commented Jun 8, 2018

Copy link
Copy Markdown
MemberAuthor

@nodejs/gyp

@TrottTrott added the python PRs and issues that require attention from people who are familiar with Python. label Jun 8, 2018
bnoordhuis
bnoordhuis approved these changes Jun 8, 2018
View reviewed changes

@bnoordhuisbnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to fast-track, IMO.

@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 8, 2018
@addaleax

addaleax commented Jun 8, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/19094/

@Trott

Trott commented Jun 8, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-commit/19102/

Trott added a commit to Trott/io.js that referenced this pull request Jun 9, 2018
@Trott
tools,gyp: fix regex for version matching
a9e70d7
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: nodejs#21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott

Trott commented Jun 9, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in a9e70d7

@TrottTrott closed this Jun 9, 2018
@egoroof

This comment was marked as abuse.

Sign in to view
@Trott

Trott commented Jun 9, 2018

Copy link
Copy Markdown
MemberAuthor

@egoroofnode-gyp released the patch for this in v3.6.3 so if you're using that version or newer of node-gyp, you should be OK.

targos pushed a commit that referenced this pull request Jun 10, 2018
@Trott@targos
tools,gyp: fix regex for version matching
c09b2bb
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Trott added a commit to Trott/io.js that referenced this pull request Jun 13, 2018
@Trott
tools,gyp: fix regex for version matching
364e123
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: nodejs#21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@Trott@MylesBorins
tools,gyp: fix regex for version matching
ac85c4c
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@Trott@MylesBorins
tools,gyp: fix regex for version matching
32f4c18
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorinsMylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@Trott@rvagg
tools,gyp: fix regex for version matching
7a35e18
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@Trott@rvagg
tools,gyp: fix regex for version matching
c210641
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Nov 24, 2018
@Trott@rvagg
tools,gyp: fix regex for version matching
038652f
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott@rvagg
tools,gyp: fix regex for version matching
772fc78
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@Trott@MylesBorins
tools,gyp: fix regex for version matching
bc916e9
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott@rvagg
tools,gyp: fix regex for version matching
a1224ef
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Trott deleted the fix-gyp branch January 13, 2022 22:49
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
@Trott@evanlucas
tools,gyp: fix regex for version matching
1e49ead
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: nodejs/node#21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@refackrefackrefack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.fast-trackPRs that do not need to wait for 48 hours to land.pythonPRs and issues that require attention from people who are familiar with Python.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@addaleax@egoroof@refack@bnoordhuis@richardlau@nodejs-github-bot