Uh oh!
There was an error while loading. Please reload this page.
test: refactoring test-repl-tab-complete with common.mustCall - #2122
Closed
thefourtheye wants to merge 1 commit into
Closed
test: refactoring test-repl-tab-complete with common.mustCall#2122thefourtheye wants to merge 1 commit into
thefourtheye wants to merge 1 commit into
Conversation
The original test uses a variable to explicitly count how many times the callback is invoked. This patch uses `common.mustCall` to track if the callback is called or not. This would make the test more robust as we don't explicitly hardcode the number of times to be called.
cjihrig
commented
Jul 7, 2015
Contributor
LGTM if the CI is happy. |
thefourtheye
commented
Jul 7, 2015
ContributorAuthor
@cjihrig Thanks :-) Can you please trigger a CI run? |
cjihrig
commented
Jul 7, 2015
Contributor
thefourtheye
commented
Jul 7, 2015
ContributorAuthor
@cjihrig Looks like the failures are not because of this change. This test passes in all the environments :-) |
cjihrig pushed a commit
that referenced
this pull request
Jul 7, 2015
The original test uses a variable to explicitly count how many times the callback is invoked. This patch uses common.mustCall() to track if the callback is called or not. This makes the test more robust, as we don't explicitly hardcode the number of times to be called. PR-URL: #2122 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig
commented
Jul 7, 2015
Contributor
Thanks, landed in 180fd39. |
mscdex pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
The original test uses a variable to explicitly count how many times the callback is invoked. This patch uses common.mustCall() to track if the callback is called or not. This makes the test more robust, as we don't explicitly hardcode the number of times to be called. PR-URL: nodejs#2122 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original test uses a variable to explicitly count how many times
the callback is invoked. This patch uses
common.mustCallto trackif the callback is called or not. This would make the test more robust
as we don't explicitly hardcode the number of times to be called.
cc @cjihrig