Uh oh!
There was an error while loading. Please reload this page.
build: use LC_ALL=en_US.UTF-8 in configure script - #21221
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Trott
commented
Jun 8, 2018
MemberAuthor
2 tasks
On SmartOS 16, at least in our CI environment, LC_ALL cannot be set to en_US, so the configuration script fails. Use en_US.UTF-8 instead.
Trott
commented
Jun 8, 2018
MemberAuthor
AIX failure is an unrelated known flaky. Re-run: https://ci.nodejs.org/job/node-test-commit-aix/15640/ |
Trott
commented
Jun 8, 2018
MemberAuthor
Oddly, the linter lost connection with Jenkins or otherwise stalled. Re-run: https://ci.nodejs.org/job/node-test-linter/19862/ |
Trott
commented
Jun 8, 2018
MemberAuthor
Same known-flaky failing on AIX. Looks like it's failed four times in a row and seems to be failing more than passing. That's unfortunate. Let's try AIX again: https://ci.nodejs.org/job/node-test-commit-aix/15644/ |
Trott
commented
Jun 8, 2018
MemberAuthor
Closing in favor of #21222 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👍 to approve fast-tracking. This will (hopefully) unbreak CI.
On SmartOS 16, at least in our CI environment, LC_ALL cannot be set to
en_US, so the configuration script fails. Use en_US.UTF-8 instead.
Simpler alternative to #21220, but will have to run CI to see if it works everywhere.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes