Revert "src: restore stdio on program exit" by evanlucas · Pull Request #21257 · nodejs/node

evanlucas · 2018-06-11T14:26:11Z

This reverts commit c2c9c0c.
It seems to be causing hangs when piping output to other processes.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

This reverts commit c2c9c0c. It seems to be causing hangs when piping output to other processes.

nodejs-github-bot · 2018-06-11T14:26:13Z

@evanlucas build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/39/pipeline

richardlau

Should we be adding a regression test for #21213? (Maybe separate PR?)

addaleax · 2018-06-11T17:26:16Z

Oh … so … about the test failure.

The original PR fixed another bug, namely #21020. I opened a PR for that, #21027, but because this had already been fixed by the other PR, I stripped it down to the tests only.

Can you include the src/node.cc part of 63806b1cd62cee61d8be121768031d50c389efd8 here? That was my original change, and it should solve the CI issue (so that we keep #21020 fixed).

Otherwise, closing all handles associated with the main event loop would also mean that `uv_tty_reset_mode()` can’t function properly because the corresponding FDs have already been closed. Fixes: nodejs#21020

addaleax · 2018-06-11T17:58:52Z

@evanlucas Took the liberty of pushing that commit into this PR, hope that’s okay – tests should look better now:

CI: https://ci.nodejs.org/job/node-test-pull-request/15396/

addaleax · 2018-06-11T20:59:43Z

After a quick chat with @evanlucas, we agreed that we’d like to fast-track this in time for the v10.x security release tomorrow. Please 👍 if you agree.

(CI is ✔️✔️✔️)

addaleax · 2018-06-11T22:17:56Z

Landed in 43fd1d7, 14dc17d

Otherwise, closing all handles associated with the main event loop would also mean that `uv_tty_reset_mode()` can’t function properly because the corresponding FDs have already been closed. Fixes: #21020 PR-URL: #21257 Reviewed-By: Richard Lau <riclau@uk.ibm.com>

This reverts commit c2c9c0c. It seems to be causing hangs when piping output to other processes. PR-URL: #21257 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

gireeshpunathil · 2018-06-12T04:37:51Z

sorry, I am unable to follow. @evanlucas / @addaleax, can you please clarify what is the current state of the code base, after this landing?

Does this fully revert src: restore stdio on program exit #20592 and take it to the state before that?
Or does it fix the reported hang but retains src: restore stdio on program exit #20592?
Or reverts src: restore stdio on program exit #20592 but address it in a new way?

addaleax · 2018-06-12T08:42:22Z

@gireeshpunathil The revert commit reverts #20592. The other commit fixes #21020, which is one of the problems addressed by #20592. The test changes for that bug came in #21027, which remain on master.

gireeshpunathil · 2018-06-12T09:02:20Z

@addaleax - thanks for the clarification, so this means the current master state is:

tty echo mode is restored on exit
stdio flow mode is NOT restored on exit
Am I right?

addaleax · 2018-06-12T09:06:11Z

@gireeshpunathil Yes, I think so.

jdx · 2018-06-13T05:34:54Z

I just tested #21020 in 10.4.1 and the bug has not regressed 👍

Thanks for all the hard work!

Node leaves stdio file descriptors in non-blocking mode when exiting. This has been reported, fixed, unfixed, ad nauseum. nodejs/node#14752 nodejs/node#17737 nodejs/node#20592 nodejs/node#21257 Should this become a problem in more places, we could add such a workaround elsewhere. But for now I'm limiting the ugliness to the unit-tests container, where we see this cause a lot of failures. Closescockpit-project#9484

Node leaves stdio file descriptors in non-blocking mode when exiting. This has been reported, fixed, unfixed, ad nauseum. nodejs/node#14752 nodejs/node#17737 nodejs/node#20592 nodejs/node#21257 Should this become a problem in more places, we could add such a workaround elsewhere. But for now I'm limiting the ugliness to the unit-tests container, where we see this cause a lot of failures. Closes#9484

Node leaves stdio file descriptors in non-blocking mode when exiting. This has been reported, fixed, unfixed, ad nauseum. nodejs/node#14752 nodejs/node#17737 nodejs/node#20592 nodejs/node#21257 Stolen from cockpit-project/cockpit@ef50d97cf4

AdamMajer · 2018-09-10T13:07:03Z

This revert broke the build of NodeJS on OBS (open build service) for openSUSE. Reverting the revert fixes problem.

FWIW, messing around with nonblocking stdio file descriptors without dup() has unintended consequences.

addaleax · 2018-09-10T13:11:58Z

@AdamMajer If you are seeing issues with building Node.js master (or some other tip-of-branch), could you open a new issue?

Reverting the revert ... otherwise stdout/stderr are left in O_NONBLOCK state on exit from Node in certain circumstances which results in failture of %install script as the stdout pipe of OBS overflows and returns EAGAIN

Otherwise, closing all handles associated with the main event loop would also mean that `uv_tty_reset_mode()` can’t function properly because the corresponding FDs have already been closed. Fixes: nodejs/node#21020 PR-URL: nodejs/node#21257 Reviewed-By: Richard Lau <riclau@uk.ibm.com>

This reverts commit c2c9c0c. It seems to be causing hangs when piping output to other processes. PR-URL: nodejs/node#21257 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

Revert "src: restore stdio on program exit"
b56788d
This reverts commit c2c9c0c. It seems to be causing hangs when piping output to other processes.

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 11, 2018

evanlucas mentioned this pull request Jun 11, 2018
source <(npm completion) doesn't end in Node v10.4.0 #21213
Closed

addaleax approved these changes Jun 11, 2018
View reviewed changes

richardlau approved these changes Jun 11, 2018
View reviewed changes

src: reset TTY mode before cleaning up resources
02ed238
Otherwise, closing all handles associated with the main event loop would also mean that `uv_tty_reset_mode()` can’t function properly because the corresponding FDs have already been closed. Fixes: nodejs#21020

addaleax added the tty Issues and PRs related to the tty subsystem. label Jun 11, 2018

addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 11, 2018

addaleax closed this Jun 11, 2018

addaleax mentioned this pull request Jun 11, 2018
nodejs sometimes leaves stdout/stderr in non-blocking mode #14752
Closed

evanlucas deleted the revertstdiorestore branch June 11, 2018 22:46

stefwalter mentioned this pull request Jun 23, 2018
unit-tests: Switch stdio to non-blocking after invoking Node.js cockpit-project/cockpit#9484
Merged

AdamMajer mentioned this pull request Sep 13, 2018
Build fails - O_NONBLOCK stdout/stderr set by node causes problems with 3rd party software #22837
Closed

mramato mentioned this pull request Oct 31, 2018
Fix "everything passes, travis fails" CesiumGS/cesium#7204
Merged

Uh oh!

Uh oh!

Conversation

evanlucas commented Jun 11, 2018

Checklist

Uh oh!

nodejs-github-bot commented Jun 11, 2018

Uh oh!

richardlau left a comment

Choose a reason for hiding this comment

Uh oh!

addaleax commented Jun 11, 2018

Uh oh!

addaleax commented Jun 11, 2018

Uh oh!

addaleax commented Jun 11, 2018

Uh oh!

addaleax commented Jun 11, 2018

Uh oh!

gireeshpunathil commented Jun 12, 2018

Uh oh!

addaleax commented Jun 12, 2018

Uh oh!

gireeshpunathil commented Jun 12, 2018

Uh oh!

addaleax commented Jun 12, 2018

Uh oh!

jdx commented Jun 13, 2018

Uh oh!

AdamMajer commented Sep 10, 2018

Uh oh!

addaleax commented Sep 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants