Uh oh!
There was an error while loading. Please reload this page.
test: add tests for process.setgroups() - #21286
Closed
shisama wants to merge 2 commits into
Closed
Conversation
Added tests to validate process.setgroups() arguments
shisamaforce-pushed
the
test-process-setgroups
branch
from
June 12, 2018 14:46
adfe065 to
b2035c8Comparetargos
approved these changes
Jun 12, 2018
richardlau
left a comment
Member
There was a problem hiding this comment.
The docs say This function is only available on POSIX platforms (i.e. not Windows or Android). so I think this test either needs to assert the function is undefined on non-POSIX or the test skipped.
richardlau
approved these changes
Jun 13, 2018
addaleax
commented
Jun 14, 2018
Member
jasnell
approved these changes
Jun 14, 2018
lpinca
approved these changes
Jun 17, 2018
jasnell pushed a commit
that referenced
this pull request
Jun 21, 2018
Added tests to validate process.setgroups() arguments PR-URL: #21286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell pushed a commit
that referenced
this pull request
Jun 21, 2018
PR-URL: #21286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell
commented
Jun 21, 2018
Member
targos pushed a commit
that referenced
this pull request
Jun 22, 2018
Added tests to validate process.setgroups() arguments PR-URL: #21286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 22, 2018
PR-URL: #21286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests to validate process.setgroups() arguments
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes