Uh oh!
There was an error while loading. Please reload this page.
[8.x] deps: V8: cherry-pick 8361fa58 from upstream - #21294
Merged
Conversation
nodejs-github-bot
commented
Jun 12, 2018
Collaborator
@ofrobots sadly an error occured when I tried to trigger a build :( |
2 tasks
MylesBorins
commented
Jun 14, 2018
Contributor
this is going to need a rebase and another CI kick off |
ofrobots
commented
Jun 14, 2018
ContributorAuthor
ofrobots
commented
Jun 15, 2018
ContributorAuthor
@mhdawson the V8-CI seems to be failing on ppcle and s390x. Any ideas why? |
ofrobots
commented
Jun 18, 2018
ContributorAuthor
@nodejs/build @mhdawson ping on the V8-CI issues above. |
mhdawson
commented
Jun 20, 2018
Member
I fixed the s390 issue a few days ago as mentioned on the other PR. |
ofrobots
commented
Jun 28, 2018
ContributorAuthor
Fresh V8 CI now that the CI issues are fixed: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1495/ |
ofrobots
commented
Jun 28, 2018
ContributorAuthor
@nodejs/lts @nodejs/v8-update this needs an LGTM before this back-port can land. |
Original commit message: [runtime] Fix derived class instantiation Bug: chromium:806388 Change-Id: Ieb343f0d532c16b6102e85222b77713f23bacf8c Reviewed-on: https://chromium-review.googlesource.com/894942 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#50990} PR-URL: nodejs#21294 Reviewed-By: Myles Borins <myles.borins@gmail.com>
ofrobots
commented
Jun 30, 2018
ContributorAuthor
Thanks!. Landed on |
Merged
rvagg pushed a commit
that referenced
this pull request
Aug 16, 2018
Original commit message: [runtime] Fix derived class instantiation Bug: chromium:806388 Change-Id: Ieb343f0d532c16b6102e85222b77713f23bacf8c Reviewed-on: https://chromium-review.googlesource.com/894942 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#50990} PR-URL: #21294 Reviewed-By: Myles Borins <myles.borins@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9.x: #21293
Original commit message:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @nodejs/v8-update