Skip to content

build: fix building with --build-v8-with-gn - #21330

Closed
hashseed wants to merge 1 commit into
nodejs:masterfrom
hashseed:obji
Closed

build: fix building with --build-v8-with-gn#21330
hashseed wants to merge 1 commit into
nodejs:masterfrom
hashseed:obji

Conversation

@hashseed

@hashseedhashseed commented Jun 14, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jun 14, 2018

Copy link
Copy Markdown
Collaborator

@hashseed build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/66/pipeline

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jun 14, 2018
@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 14, 2018
@refack

refack commented Jun 14, 2018

Copy link
Copy Markdown
Contributor

I'm fine with landing this with only lite-CI/Travis since we have no further coverage of this in our CI

@refackrefack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 14, 2018
@hashseed

hashseed commented Jun 20, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in ed1035d

hashseed added a commit that referenced this pull request Jun 20, 2018
@hashseed
build: fix building with --build-v8-with-gn
ed1035d
PR-URL: #21330
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targostargos closed this Jun 20, 2018
targos pushed a commit that referenced this pull request Jun 20, 2018
@hashseed@targos
build: fix building with --build-v8-with-gn
c214403
PR-URL: #21330
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targostargos mentioned this pull request Jul 3, 2018
Merged
@hashseed
hashseed deleted the obji branch July 13, 2018 06:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+2 more reviewers
@refackrefackrefack approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@hashseed@nodejs-github-bot@refack@bnoordhuis@jasnell@addaleax@TimothyGu@targos@cjihrig@richardlau@BridgeAR