Skip to content

deps: float 3984ef0 from openssl / CVE-2018-0732 (8.x backport) - #21343

Closed
rvagg wants to merge 1 commit into
nodejs:v8.x-stagingfrom
rvagg:rvagg/openssl-3984ef0-v8.x
Closed

deps: float 3984ef0 from openssl / CVE-2018-0732 (8.x backport)#21343
rvagg wants to merge 1 commit into
nodejs:v8.x-stagingfrom
rvagg:rvagg/openssl-3984ef0-v8.x

Conversation

@rvagg

@rvaggrvagg commented Jun 15, 2018

Copy link
Copy Markdown
Member

Backport of #21282 but for OpenSSL 1.0.2

I'm not sure what 8.x lts label this should get, if any, so help would be appreciated.

Pending OpenSSL 1.0.2p release.
Ref: https://github.com/nodejs/node/pull/21282
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Upstream: https://github.com/openssl/openssl/commit/3984ef0
Original commit message:
Reject excessively large primes in DH key generation.
CVE-2018-0732
Signed-off-by: Guido Vranken <guidovranken@gmail.com>
(cherry picked from commit 91f7361)
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #6457)

@rvagg
deps: float 3984ef0 from openssl /CVE-2018-0732
32cfbfa
Pending OpenSSL 1.0.2p release.
Ref: nodejs#21282
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Upstream: openssl/openssl@3984ef0
Original commit message:
Reject excessively large primes in DH key generation.
CVE-2018-0732
Signed-off-by: Guido Vranken <guidovranken@gmail.com>
(cherry picked from commit 91f7361)
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from nodejs#6457)
@rvaggrvagg added openssl Issues and PRs related to the OpenSSL dependency. security Issues and PRs related to security. labels Jun 15, 2018
@nodejs-github-bot

nodejs-github-bot commented Jun 15, 2018

Copy link
Copy Markdown
Collaborator

@rvagg build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/73/pipeline

@nodejs-github-botnodejs-github-bot added openssl Issues and PRs related to the OpenSSL dependency. v8.x labels Jun 15, 2018
@rvaggrvagg mentioned this pull request Jun 15, 2018
Closed
@rvagg

rvagg commented Jun 18, 2018

Copy link
Copy Markdown
MemberAuthor

31a571d

@rvaggrvagg closed this Jun 18, 2018
@rvagg
rvagg deleted the rvagg/openssl-3984ef0-v8.x branch June 18, 2018 04:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

Assignees

No one assigned

Labels

opensslIssues and PRs related to the OpenSSL dependency.securityIssues and PRs related to security.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rvagg@nodejs-github-bot@jasnell