Uh oh!
There was an error while loading. Please reload this page.
deps: float 949ff366 from openssl (ECDSA blinding) (8.x backport) - #21346
Closed
rvagg wants to merge 1 commit into
Closed
deps: float 949ff366 from openssl (ECDSA blinding) (8.x backport)#21346rvagg wants to merge 1 commit into
rvagg wants to merge 1 commit into
Conversation
Pending OpenSSL 1.0.2p release. Ref: https://www.nccgroup.trust/us/our-research/technical-advisory-return-of-the-hidden-number-problem/ Ref: nodejs#21345 Upstream: openssl/openssl@949ff366 Original commit message: Add blinding to an ECDSA signature Keegan Ryan (NCC Group) has demonstrated a side channel attack on an ECDSA signature operation. During signing the signer calculates: s:= k^-1 * (m + r * priv_key) mod order The addition operation above provides a sufficient signal for a flush+reload attack to derive the private key given sufficient signature operations. As a mitigation (based on a suggestion from Keegan) we add blinding to the operation so that: s := k^-1 * blind^-1 (blind * m + blind * r * priv_key) mod order Since this attack is a localhost side channel only no CVE is assigned. Reviewed-by: Rich Salz <rsalz@openssl.org>
bnoordhuis
approved these changes
Jun 15, 2018
shigeki
approved these changes
Jun 15, 2018
shigeki
left a comment
Contributor
There was a problem hiding this comment.
CI of plinux was failed due to Jenkins error.
CI is again in https://ci.nodejs.org/job/node-test-pull-request/15483/.
jasnell
approved these changes
Jun 15, 2018
rvagg
commented
Jun 18, 2018
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #21345 but for 1.0.2 on 8.x.
Pending OpenSSL 1.0.2p release.
Ref: https://www.nccgroup.trust/us/our-research/technical-advisory-return-of-the-hidden-number-problem/
Ref: #21345
Upstream: openssl/openssl@949ff366
Original commit message: