test: make cctest fixture use node::NewIsolate

[danbev]

This commit updates the gtest fixture to use node::NewIsolate instead of
creating a new V8 Isolate using v8::Isolate::New.

The motivation for this is that without calling node::NewIsolate the
various callbacks set on the isolate, for example AddMessageListener,
SetFatalErrorHandler etc, would not get set. I don't think this is the
expected behaviour and I ran into this when writing a new cctest.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/103/pipeline

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/15531/

[danbev]

node-test-commit-aix failure looks unrelated

console output:

03:24:59 Node.js major version: -103:24:59 Node.js version: null03:24:59 Running nodes03:24:59 Triggering node-test-commit-aix » aix61-ppc6403:55:03 Completed node-test-commit-aix » aix61-ppc64 FAILURE03:55:03 All downstream projects complete!03:55:03 Notifying upstream projects of job completion03:55:03 Finished: FAILURE

[bnoordhuis]

This looks mildly questionable. Why not e.g.:

allocator = ArrayBufferUniquePtr(node::CreateArrayBufferAllocator(), &node::FreeArrayBufferAllocator);

(Might need a std::move().)

[danbev]

I used reset mainly to follow the pattern of the other unique_ptr's in that file but this would be much cleaner. I'll update shortly. Thanks

[danbev]

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/15596/

[danbev]

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/15631/

[danbev]

Landed in d6f7a32, and 8326bea.