Uh oh!
There was an error while loading. Please reload this page.
src: fix debugging for multiple categories - #21422
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Fix parsing of e.g. `NODE_DEBUG_NATIVE=worker,messaging`.
addaleax
commented
Jun 20, 2018
MemberAuthor
Full CI: https://ci.nodejs.org/job/node-test-pull-request/15535/ Feel free to 👍 this for fast-tracking. |
cjihrig
approved these changes
Jun 20, 2018
BridgeAR
approved these changes
Jun 20, 2018
Trott
commented
Jun 20, 2018
Member
CI re-run to see if AIX is clear now: https://ci.nodejs.org/job/node-test-pull-request/15539/ |
addaleax
commented
Jun 20, 2018
MemberAuthor
Landed in 7aa9567 |
addaleax added a commit
that referenced
this pull request
Jun 20, 2018
Fix parsing of e.g. `NODE_DEBUG_NATIVE=worker,messaging`. PR-URL: #21422 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit
that referenced
this pull request
Jun 22, 2018
Fix parsing of e.g. `NODE_DEBUG_NATIVE=worker,messaging`. PR-URL: #21422 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix parsing of e.g.
NODE_DEBUG_NATIVE=worker,messaging.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes