Uh oh!
There was an error while loading. Please reload this page.
src: add native debugging code to workers - #21423
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Now that we have better native debugging utilities in core, let’s use them :)
addaleax
commented
Jun 20, 2018
MemberAuthor
devsnek
approved these changes
Jun 20, 2018
cjihrig
approved these changes
Jun 20, 2018
jasnell
approved these changes
Jun 21, 2018
TimothyGu
approved these changes
Jun 21, 2018
mmarchini
approved these changes
Jun 21, 2018
targos
commented
Jun 24, 2018
Member
apapirovski
commented
Jun 25, 2018
Contributor
Landed in 018d618 |
apapirovski pushed a commit
that referenced
this pull request
Jun 25, 2018
Now that we have better native debugging utilities in core, let’s use them :) PR-URL: #21423 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
targos pushed a commit
that referenced
this pull request
Jun 25, 2018
Now that we have better native debugging utilities in core, let’s use them :) PR-URL: #21423 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have better native debugging utilities in core,
let’s use them :)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes