Uh oh!
There was an error while loading. Please reload this page.
fs: fix fsPromises.lchmod errors on non-Mac - #21435
Merged
ChALkeR merged 1 commit intoJul 10, 2018
Merged
Conversation
cjihrig
approved these changes
Jun 21, 2018
starkwang
approved these changes
Jun 21, 2018
ChALkeR
approved these changes
Jun 21, 2018
BridgeAR
approved these changes
Jun 21, 2018
BridgeAR
commented
Jun 21, 2018
Member
jasnell
approved these changes
Jun 21, 2018
trivikr
approved these changes
Jun 22, 2018
shisama
commented
Jun 22, 2018
ContributorAuthor
I think CI failures are unrelated to this. |
targos
commented
Jun 24, 2018
Member
Member
apapirovski
commented
Jun 25, 2018
Contributor
shisama
commented
Jun 30, 2018
ContributorAuthor
Thanks to #21498 , we can use |
shisamaforce-pushed
the
fix-fs-promises-err-method-not-implemented
branch
from
June 30, 2018 12:32
f66c492 to
5aef2d8CompareContributorAuthor
@ChALkeR@jasnell@cjihrig@BridgeAR@starkwang@trivikr@targos@apapirovski Now, we can use |
cjihrig
commented
Jun 30, 2018
Contributor
Still LGTM. Thanks for updating this. |
hiroppy
approved these changes
Jun 30, 2018
ChALkeR
approved these changes
Jun 30, 2018
On non-macOS, fsPromises.lchmod throws AssertionError.
Expected behavior is `Error [ERR_METHOD_NOT_IMPLEMENTED]`.
`ERR_METHOD_NOT_IMPLEMENTED()` requires argument, but it wasn't set.
Fixes `ERR_METHOD_NOT_IMPLEMENTED()` to
`ERR_METHOD_NOT_IMPLEMENTED('lchmod()')`.
PR-URL: nodejs#21435
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>ChALkeRforce-pushed
the
fix-fs-promises-err-method-not-implemented
branch
from
July 10, 2018 17:02
5aef2d8 to
f54958eCompareMember
Looks like no objections. Rebased, commit message updated to exclude mentions of lchown, preparing to land. |
ChALkeR
commented
Jul 10, 2018
Member
Member
Landed in f54958e, thanks all! 🎉 |
targos pushed a commit
that referenced
this pull request
Jul 12, 2018
On non-macOS, fsPromises.lchmod throws AssertionError.
Expected behavior is `Error [ERR_METHOD_NOT_IMPLEMENTED]`.
`ERR_METHOD_NOT_IMPLEMENTED()` requires argument, but it wasn't set.
Fixes `ERR_METHOD_NOT_IMPLEMENTED()` to
`ERR_METHOD_NOT_IMPLEMENTED('lchmod()')`.
PR-URL: #21435
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Merged
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On non-macOS, fsPromises.lchmod and lchown throws AssertionError.
Expected behavior is
Error [ERR_METHOD_NOT_IMPLEMENTED].ERR_METHOD_NOT_IMPLEMENTED()requires argument, but it didn't set.Fixes
ERR_METHOD_NOT_IMPLEMENTED()toERR_METHOD_NOT_IMPLEMENTED('lchmod')or
ERR_METHOD_NOT_IMPLEMENTED('lchown').Fixes: #21421
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes- [ ] documentation is changed or added