Solve fix inconsistent (hostname vs host) in DNS. #20892

[UlisesGascon]

Hi team!

This change is related to #20892. I fixed the inconsistency between host and hostname in the DNS source code and test. I followed the URL guide provided in the official Documentation.

This is my first contribution to Nodejs, so please let me know if I am doing something wrong ;-)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[UlisesGascon]

mm... Not sure what is broken with the Build

[mscdex]

The CI job output shows:

not ok 434 parallel/test-dns
---
duration_ms: 0.140
severity: fail
exitcode: 1
stack: |-
/home/travis/build/nodejs/node/test/common/index.js:752
throw new assert.AssertionError({
^
AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
+ expected - actual
Comparison {
code: 'ERR_MISSING_ARGS',
type: [Function: TypeError],
- message: 'The "hostname", "port", and "callback" arguments must be specified'
+ message: 'The "host", "port", and "callback" arguments must be specified'
}
at new AssertionError (internal/assert.js:268:11)
at Object.innerFn (/home/travis/build/nodejs/node/test/common/index.js:752:15)
at expectedException (assert.js:487:19)
at expectsError (assert.js:581:16)
at Function.throws (assert.js:612:3)
at Object.expectsError (/home/travis/build/nodejs/node/test/common/index.js:764:12)
at Object.<anonymous> (/home/travis/build/nodejs/node/test/parallel/test-dns.js:252:10)
at Module._compile (internal/modules/cjs/loader.js:689:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
at Module.load (internal/modules/cjs/loader.js:599:32)

[UlisesGascon]

Thanks @mscdex ! I will fix that asap ;-)

[addaleax]

@UlisesGascon Do you think you could fix that CI failure here?

[jasnell]

What's the status on this one?

[shakeelmohamed]

I've got a fix for this and will open a PR to replace this one

[UlisesGascon]

thanks @shakeelmohamed!