Skip to content

doc: show options arg to new Worker is optional - #21508

Closed
watson wants to merge 1 commit into
nodejs:masterfrom
watson:wt
Closed

doc: show options arg to new Worker is optional#21508
watson wants to merge 1 commit into
nodejs:masterfrom
watson:wt

Conversation

@watson

@watsonwatson commented Jun 24, 2018

Copy link
Copy Markdown
Member
Checklist

@watsonwatson added the worker Issues and PRs related to Worker support. label Jun 24, 2018
@nodejs-github-bot

nodejs-github-bot commented Jun 24, 2018

Copy link
Copy Markdown
Collaborator

@watson build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/145/pipeline

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 24, 2018
@vsemozhetbyt

vsemozhetbyt commented Jun 24, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Refs:

node/lib/internal/worker.js

Lines 206 to 207 in 8ab7ea6

classWorkerextendsEventEmitter{
constructor(filename,options={}){

@vsemozhetbyt

vsemozhetbyt commented Jun 24, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbytvsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 24, 2018
benjamingr
benjamingr approved these changes Jun 24, 2018
View reviewed changes

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

watson added a commit that referenced this pull request Jun 24, 2018
@watson
doc: show options arg to new Worker is optional
e22d709
PR-URL: #21508
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@watson

watson commented Jun 24, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in e22d709

@watsonwatson closed this Jun 24, 2018
@watson
watson deleted the wt branch June 24, 2018 19:10
targos pushed a commit that referenced this pull request Jun 25, 2018
@watson@targos
doc: show options arg to new Worker is optional
dbd810e
PR-URL: #21508
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targostargos mentioned this pull request Jul 3, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@watson@nodejs-github-bot@vsemozhetbyt@benjamingr@targos@cjihrig@trivikr