Skip to content

worker: add test for messagePort.onmessage - #21510

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:test-worker-onmessage
Closed

worker: add test for messagePort.onmessage#21510
targos wants to merge 1 commit into
nodejs:masterfrom
targos:test-worker-onmessage

Conversation

@targos

@targostargos commented Jun 24, 2018

Copy link
Copy Markdown
Member

@nodejs/workers

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@targostargos added test Issues and PRs related to the tests. worker Issues and PRs related to Worker support. labels Jun 24, 2018
@nodejs-github-bot

nodejs-github-bot commented Jun 24, 2018

Copy link
Copy Markdown
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/146/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jun 24, 2018
benjamingr
benjamingr approved these changes Jun 24, 2018
View reviewed changes

@benjamingrbenjamingr left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM :) Would be great if you could come up with ideas for tests for worker and make them good-first-contribution

Also, maybe add yourself to @nodejs/workers?

@targos

targos commented Jun 24, 2018

Copy link
Copy Markdown
MemberAuthor

Would be great if you could come up with ideas for tests for worker and make them good-first-contribution

Writing tests is a good way for me to test if the API meets my expectations, but I'll keep that in mind :)

Also, maybe add yourself to @nodejs/workers?

Thanks for the suggestion, done!

@TimothyGu

TimothyGu commented Jun 24, 2018

Copy link
Copy Markdown
Member

There should be an equivalent test for MessageChannel and MessagePort themselves in test/parallel/test-message-port.js

@benjamingr

benjamingr commented Jun 24, 2018

Copy link
Copy Markdown
Member

@itaysabato do you want to take a stab at those tests @TimothyGu just outlined in #21510 (comment)?

@benjamingrbenjamingr mentioned this pull request Jun 24, 2018
Closed
@itaysabatoitaysabato mentioned this pull request Jun 24, 2018
Closed
3 tasks
@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 25, 2018
@trivikr

trivikr commented Jun 25, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/15603/

@targos

targos commented Jun 25, 2018

Copy link
Copy Markdown
MemberAuthor

Note to self: change commit prefix to test:

jasnell pushed a commit that referenced this pull request Jun 29, 2018
@targos@jasnell
workers: add test for messagePort.onmessage
f5db04d
PR-URL: #21510
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Jun 29, 2018

Copy link
Copy Markdown
Member

Landed in f5db04d

@jasnelljasnell closed this Jun 29, 2018
@targos
targos deleted the test-worker-onmessage branch June 29, 2018 18:52
@Trott

Trott commented Jun 29, 2018

Copy link
Copy Markdown
Member

This landed without the commit message change. Probably not a big deal, only affects the CHANGELOG/Release Notes?

targos added a commit that referenced this pull request Jun 29, 2018
@targos
workers: add test for messagePort.onmessage
41c4b2c
PR-URL: #21510
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Jun 29, 2018

Copy link
Copy Markdown
Member

Ah... just saw the note to self from @targos ... yeah, I don't think it's super critical

@targostargos mentioned this pull request Jul 3, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@trivikrtrivikrtrivikr approved these changes
+3 more reviewers
@TimothyGuTimothyGuTimothyGu approved these changes
@hiroppyhiroppyhiroppy approved these changes
@starkwangstarkwangstarkwang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@targos@nodejs-github-bot@TimothyGu@benjamingr@trivikr@jasnell@Trott@lpinca@cjihrig@hiroppy@starkwang