Skip to content

crypto: remove outdated comment - #21511

Closed
TimothyGu wants to merge 1 commit into
nodejs:masterfrom
TimothyGu:remove-crypto-comment
Closed

crypto: remove outdated comment#21511
TimothyGu wants to merge 1 commit into
nodejs:masterfrom
TimothyGu:remove-crypto-comment

Conversation

@TimothyGu

@TimothyGuTimothyGu commented Jun 24, 2018

Copy link
Copy Markdown
Member

Fixes: #21488

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@TimothyGuTimothyGu added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 24, 2018
@nodejs-github-bot

nodejs-github-bot commented Jun 24, 2018

Copy link
Copy Markdown
Collaborator

@TimothyGu build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/147/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Jun 24, 2018
@TimothyGu

TimothyGu commented Jun 24, 2018

Copy link
Copy Markdown
MemberAuthor

Please 👍 for fast-tracking.

CI: https://ci.nodejs.org/job/node-test-pull-request/15585/

TimothyGu added a commit to TimothyGu/node that referenced this pull request Jun 24, 2018
@TimothyGu
crypto: remove outdated comment
6396574
PR-URL: nodejs#21511Fixes: nodejs#21488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@TimothyGu

TimothyGu commented Jun 24, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 6396574.

@TimothyGu
TimothyGu deleted the remove-crypto-comment branch June 24, 2018 22:03
targos pushed a commit that referenced this pull request Jun 25, 2018
@TimothyGu@targos
crypto: remove outdated comment
fefa57a
PR-URL: #21511Fixes: #21488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request Jul 3, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Menacing thread safety comment in node_crypto.cc

4 participants

@TimothyGu@nodejs-github-bot@targos@cjihrig