Skip to content

test: add worker prefix to test-message* tests - #21512

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:move-worker-tests
Closed

test: add worker prefix to test-message* tests#21512
targos wants to merge 1 commit into
nodejs:masterfrom
targos:move-worker-tests

Conversation

@targos

Copy link
Copy Markdown
Member

It makes it easier to locate all tests related to the worker subsystem.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jun 24, 2018
@targostargos added the worker Issues and PRs related to Worker support. label Jun 24, 2018
@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 25, 2018
@trivikr

Copy link
Copy Markdown
Member

@targos
targosforce-pushed the move-worker-tests branch from a07be77 to d1f6b2fCompareJune 30, 2018 09:41
It makes it easier to locate all tests related to the worker subsystem.
@targos
targosforce-pushed the move-worker-tests branch from d1f6b2f to bdcb272CompareJune 30, 2018 13:02
@targos

Copy link
Copy Markdown
MemberAuthor

@targos

Copy link
Copy Markdown
MemberAuthor

Landed in b87b164

@targostargos closed this Jun 30, 2018
@targos
targos deleted the move-worker-tests branch June 30, 2018 16:26
targos added a commit that referenced this pull request Jun 30, 2018
It makes it easier to locate all tests related to the worker subsystem.
PR-URL: #21512
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
targos added a commit that referenced this pull request Jul 3, 2018
It makes it easier to locate all tests related to the worker subsystem.
PR-URL: #21512
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@targostargos mentioned this pull request Jul 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.workerIssues and PRs related to Worker support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@targos@nodejs-github-bot@trivikr@jasnell@lpinca@TimothyGu@cjihrig@hiroppy@JungMinu