repl: fix tab completion for object properties with special characters

[starkwang]

The old RegExp will pass property names like "hello world!" when filtering the results of tab complete. This change is to fix it.

By the way, now the repl module doesn't support tab complete like obj[<tab>. Is there any plan for this?

Fixes: #21201

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

@starkwang build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/165/pipeline

[addaleax]

Would it be possible to generate proper tab completions for the other keys? I.e. autocomplete obj.hello to obj['hello, world']?

[TimothyGu]

You might find https://github.com/devsnek/node-repl-prototype/blob/5e72bed5a127c0b3e1c7289d75c3eb157db43522/src/repl.js#L154-L169 to be helpful to enhance the behavior for [ property references.

[TimothyGu]

With acorn in tree, we could actually do something like

https://github.com/devsnek/node-repl-prototype/blob/5e72bed5a127c0b3e1c7289d75c3eb157db43522/src/util.js#L3-L24

for higher accuracy.

[starkwang]

Would it be possible to generate proper tab completions for the other keys? I.e. autocomplete obj.hello to obj['hello, world']?

@addaleax Rewrite the user input from obj.hello to obj['hello, world'] might exceed the scope of autocomplete. It should not rewrite but append something after the user input.

[starkwang]

CI before landing: https://ci.nodejs.org/job/node-test-pull-request/15704/

[starkwang]

Landed in 4f15122