[8.x] deps: V8: backport 20 CPU profiler commits from upstream by psmarshall · Pull Request #21558 · nodejs/node

psmarshall · 2018-06-27T07:51:28Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

[cpu-profiler] Fix bugs and add tests for JITLineInfoTable
https://chromium.googlesource.com/v8/v8/+/4feb5ce7fd5ef8c933f3f5dff2eca1173f85c1e9

[cpu-profiler] Fix incorrect line number calculation.
https://chromium.googlesource.com/v8/v8/+/ddb2856f39632f9e9f623d3cdb4600e636172031

[cpu-profiler] Use std::unordered_map for hashmaps.
https://chromium.googlesource.com/v8/v8/+/35985ce6abc80b85264fe3b87b246fed5f1806e6

[cpu-profiler] Do not store CodeEntries between profiling sessions.
https://chromium.googlesource.com/v8/v8.git/+/8ec48b2117b8092c4956f1ee11a0c85bec3ba1f8

[cpu-profiler] Remove name_prefix field from CodeEntry
https://chromium.googlesource.com/v8/v8.git/+/6f72af25fe43218b60c68129073ddcddb631566e

[cpu-profiler] Extract rare used fields of CodeEntry to an optional object.
https://chromium.googlesource.com/v8/v8.git/+/fcc1ebb55aab38013855834f556f6e874e0eb8b3

[profiler] Refactoring: decouple StringsStorage from Heap object.
https://chromium.googlesource.com/v8/v8/+/a31320f59c911a277566d6c2fa0b0f2ac83e0748

[cpu-profiler] Add a HandleScope to limit memory consumption.
https://chromium.googlesource.com/v8/v8.git/+/3e9f8a4f635e2d946651d6a4df81378266f32dc9

[cpu-profiler] Lazily create CPU profiler.
https://chromium.googlesource.com/v8/v8/+/1426ea1d6d45be0b4d9476bdb5bf3f27cfe578a0

[cpu-profiler] turn several std::map's into unordered_map's.
https://chromium.googlesource.com/v8/v8/+/3ed5dfb8a3cbc7aa0017bd01c2fdd6227485b8ad

[cpu-profiler] Eagerly delete not used CodeEntry'es
https://chromium.googlesource.com/v8/v8.git/+/c6c28f7a412a88df12055e953630a9e93cc64d49

[cpu-profiler] Move bailout reason into rare_info struct
https://chromium.googlesource.com/v8/v8.git/+/29ea4d1ef5360e71c61ecf8db6a5a0a0c3391fd1

[cpu-profiler] Save space in the SourcePositionTable by using a vector.
https://chromium.googlesource.com/v8/v8.git/+/1cb19f0e0a93adbac8c11bc906f951bd8098722d

[cpu-profiler] Only store deopt inline frames for functions that need it
https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b

[cpu-profiler] Add a new profiling mode with a more detailed call tree.
https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77

[cpu-profiler] Reuse free slots in code_entries_
https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a

[cpu-profiler] Use instruction start as the key for the CodeMap
https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66

ofrobots · 2018-06-27T15:41:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/15653/
Will launch V8-CI once #21433 is resolved.

ofrobots · 2018-06-27T15:43:38Z

The V8 version in v8-version.h will need to be bumped.

/cc @nodejs/v8-update

ofrobots · 2018-06-27T18:45:10Z

Relaunched suspected flakes/infra issues:

linuxone build: https://ci.nodejs.org/job/node-test-commit-linuxone/2616/
linter: https://ci.nodejs.org/job/node-test-linter/20332/

psmarshall · 2018-07-02T10:34:10Z

Thanks, bumped v8-version

ofrobots · 2018-07-02T17:10:39Z

CI is green. V8-CI is functional now, so here's a launch: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1504/

/fyi @nodejs/diagnostics: This improves the memory overhead of the CPU profiler. These fixes are available on 10 (all commits except the last one are in V8 6.7), and this PR backports them to Node 8.

/cc @nodejs/lts.

mcollina

rubberstamp LGTM

hashseed · 2018-07-03T10:22:30Z

The V8 version in v8-version.h will need to be bumped.

I thought we bump the embedder string for backmerges.

targos · 2018-07-03T11:16:21Z

@hashseed the embedder string doesn't exist in v8.x

MylesBorins

LGTM

MylesBorins · 2018-07-09T20:12:20Z

landed in b57ad02

ofrobots · 2018-07-09T20:54:33Z

Oops, I messed. I intended to add this comment here, but put it on the wrong issue: #21334 (comment).

Actually, I was mistaken, these fixes not in 10 just yet. They are in V8 6.8 (rather than 6.7). Let's hold off on landing this until a 10.x release picks them up.

ofrobots · 2018-07-09T20:54:51Z

@MylesBorins is it possible to revert these commits from 8.x?

MylesBorins · 2018-07-10T14:08:21Z

I've backed the commit out of staging and the 8.12.0 proposal

ofrobots · 2018-07-10T14:41:08Z

Thanks. I've added the in progress label to make sure it doesn't get re-landed until it is time.

psmarshall · 2018-07-24T08:15:54Z

Note to self: Add this one too if it's fine on 10, it's the new API:
https://chromium.googlesource.com/v8/v8/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77

hashseed · 2018-07-24T08:20:32Z

I don't have any technical objections against the new API.

MylesBorins · 2018-08-17T21:04:00Z

@psmarshall would you be able to rebase? Are these commits now out in the wild as of the latest 10.x?

psmarshall · 2018-08-22T13:48:09Z

@MylesBorins They aren't released yet: still waiting on #22028. I'll rebase 👍

Flarna · 2018-09-25T09:02:48Z

@psmarshall any chance that this is continued?

I created #23070 yesterday and according to @ofrobots this PR should fix this.

psmarshall · 2018-09-25T09:48:58Z

@Flarna I've just rebased this and the changes have landed in Node 10 so we are good to go with this PR 👍

@MylesBorins I'm ready to land 🚀

MylesBorins · 2018-09-25T14:46:32Z

Let's do one more round of CI and then land

V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1714/

BethGriggs · 2018-10-02T15:12:24Z

Another V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1724

MylesBorins · 2018-10-02T15:14:17Z

looks like compilation errors

11:22:43 make[2]: *** [/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ubuntu1604-intel-64/v8test/v8test/deps/v8/out/x64.release/obj.target/cctest/test/cctest/test-log.o] Error 1
11:22:43 make[2]: *** Waiting for unfinished jobs....
11:22:43 12 errors generated.
11:22:43 test/cctest/cctest.target.x64.release.mk:370: recipe for target '/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ubuntu1604-intel-64/v8test/v8test/deps/v8/out/x64.release/obj.target/cctest/test/cctest/test-cpu-profiler.o' failed
11:22:43 make[2]: *** [/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ubuntu1604-intel-64/v8test/v8test/deps/v8/out/x64.release/obj.target/cctest/test/cctest/test-cpu-profiler.o] Error 1
11:22:43 2 errors generated.
11:22:43 test/cctest/cctest.target.x64.release.mk:370: recipe for target '/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ubuntu1604-intel-64/v8test/v8test/deps/v8/out/x64.release/obj.target/cctest/test/cctest/test-profile-generator.o' failed
11:22:43 make[2]: *** [/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ubuntu1604-intel-64/v8test/v8test/deps/v8/out/x64.release/obj.target/cctest/test/cctest/test-profile-generator.o] Error 1
11:22:56 rm bdc92efe44eca1954fdff70fd086c7e138d0fbb1.intermediate
11:22:56 Makefile:319: recipe for target 'x64.release' failed
11:22:56 make[1]: *** [x64.release] Error 2
11:22:56 Makefile:215: recipe for target 'v8' failed
11:22:56 make: *** [v8] Error 2
11:22:56 Build step 'Execute shell' marked build as failure
11:22:56 Recording test results

/cc @psmarshall @hashseed

psmarshall · 2018-10-04T10:51:45Z

@MylesBorins Thanks, the cctest build was failing, I fixed a few issues there and it passes locally now. I added this backport (#22688) that we did to v10.x, too.

rvagg · 2018-10-04T13:40:28Z

v8 tests https://ci.nodejs.org/job/node-test-commit-v8-linux/1729/
full ci https://ci.nodejs.org/job/node-test-pull-request/17629/

rvagg · 2018-10-04T14:20:37Z

debian8 failure unrelated (although concerning), this seems good to go

Trott · 2018-10-11T20:14:24Z

Linux CI rebuild: https://ci.nodejs.org/job/node-test-commit-linux/22248/

I think (once that is green/yellow) this is good to land? Or...? /ping @BethGriggs @MylesBorins

BethGriggs · 2018-10-12T20:46:15Z

Landed in 48f31bd v8.x-staging

nodejs-github-bot added v8 engine Issues and PRs related to the V8 dependency. v8.x labels Jun 27, 2018

psmarshall force-pushed the backport-cpu-profiler-to-v8.x branch from 4e8e721 to d5ce285Compare June 27, 2018 07:52

psmarshall force-pushed the backport-cpu-profiler-to-v8.x branch 3 times, most recently from 4b64845 to a2ae646Compare July 2, 2018 10:33

mcollina approved these changes Jul 3, 2018
View reviewed changes

MylesBorins approved these changes Jul 9, 2018
View reviewed changes

MylesBorins closed this Jul 9, 2018

MylesBorins mentioned this pull request Jul 9, 2018
v8.12.0 proposal #21593
Merged

ofrobots mentioned this pull request Jul 9, 2018
[8.x] deps: V8: backport 49712d8a from upstream #21334
Closed
2 tasks

MylesBorins reopened this Jul 10, 2018

ofrobots added the wip Issues and PRs that are still a work in progress. label Jul 10, 2018

psmarshall force-pushed the backport-cpu-profiler-to-v8.x branch from a2ae646 to 5f19136Compare July 30, 2018 09:37

psmarshall changed the title ~~[8.x] deps: V8: backport 14 CPU profiler commits from upstream~~[8.x] deps: V8: backport 17 CPU profiler commits from upstreamJul 30, 2018

rvagg force-pushed the v8.x-staging branch from 0c9760d to ee9dab7Compare August 16, 2018 01:39

MylesBorins force-pushed the v8.x-staging branch from ee9dab7 to 69efa9fCompare August 16, 2018 05:59

ofrobots mentioned this pull request Sep 25, 2018
Memory Leak in V8 CpuProfiler #23070
Closed

psmarshall force-pushed the backport-cpu-profiler-to-v8.x branch from 4fc6108 to d191d39Compare September 25, 2018 09:45

hashseed approved these changes Sep 25, 2018
View reviewed changes

psmarshall force-pushed the backport-cpu-profiler-to-v8.x branch from d191d39 to 79bacf9Compare October 4, 2018 10:48

psmarshall changed the title ~~[8.x] deps: V8: backport 17 CPU profiler commits from upstream~~[8.x] deps: V8: backport 20 CPU profiler commits from upstreamOct 4, 2018

rvagg approved these changes Oct 4, 2018
View reviewed changes

ofrobots removed blocked PRs that are blocked by other issues or PRs. wip Issues and PRs that are still a work in progress. labels Oct 4, 2018

BethGriggs closed this Oct 12, 2018

BethGriggs added the backported-to-v8.x label Oct 12, 2018

BethGriggs mentioned this pull request Oct 30, 2018
v8.13.0 proposal #23974
Merged

beevelop mentioned this pull request Nov 20, 2018
2018-11-20 Version 8.13.0 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#250
Closed

Uh oh!

Uh oh!

Conversation

psmarshall commented Jun 27, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

ofrobots commented Jun 27, 2018

Uh oh!

ofrobots commented Jun 27, 2018

Uh oh!

ofrobots commented Jun 27, 2018

Uh oh!

psmarshall commented Jul 2, 2018

Uh oh!

ofrobots commented Jul 2, 2018

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

hashseed commented Jul 3, 2018

Uh oh!

targos commented Jul 3, 2018

Uh oh!

MylesBorins left a comment

Choose a reason for hiding this comment

Uh oh!

MylesBorins commented Jul 9, 2018

Uh oh!

ofrobots commented Jul 9, 2018

Uh oh!

ofrobots commented Jul 9, 2018

Uh oh!

MylesBorins commented Jul 10, 2018

Uh oh!

ofrobots commented Jul 10, 2018

Uh oh!

psmarshall commented Jul 24, 2018

Uh oh!

hashseed commented Jul 24, 2018

Uh oh!

MylesBorins commented Aug 17, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

psmarshall commented Aug 22, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flarna commented Sep 25, 2018

Uh oh!

psmarshall commented Sep 25, 2018

Uh oh!

MylesBorins commented Sep 25, 2018

Uh oh!

BethGriggs commented Oct 2, 2018

Uh oh!

MylesBorins commented Oct 2, 2018

Uh oh!

psmarshall commented Oct 4, 2018

Uh oh!

rvagg commented Oct 4, 2018

Uh oh!

rvagg commented Oct 4, 2018

Uh oh!

Trott commented Oct 11, 2018

Uh oh!

BethGriggs commented Oct 12, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

psmarshall commented Jun 27, 2018•
edited
Loading

MylesBorins commented Aug 17, 2018•
edited
Loading

psmarshall commented Aug 22, 2018•
edited
Loading

BethGriggs commented Oct 12, 2018•
edited
Loading