Uh oh!
There was an error while loading. Please reload this page.
zlib: fix memory leak for unused zlib instances - #21607
Merged
Merged
Conversation
addaleax
commented
Jun 30, 2018
MemberAuthor
tniessen
approved these changes
Jun 30, 2018
addaleax
commented
Jul 1, 2018
MemberAuthor
Fixed up the test since it was failing on a few platforms, new CI: https://ci.nodejs.org/job/node-test-pull-request/15700/ |
An oversight in an earlier commit led to a memory leak in the untypical situation that zlib instances are created but never used, because zlib handles no longer started out their life as weak handles. The bug was introduced in bd20110. Refs: nodejs#20455 PR-URL: nodejs#21607 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleaxforce-pushed
the
zlib-weak-by-default
branch
from
July 3, 2018 17:23
8c512a7 to
6e16ad7Compareaddaleax
commented
Jul 3, 2018
MemberAuthor
Landed in 6e16ad7 |
targos pushed a commit
that referenced
this pull request
Jul 4, 2018
An oversight in an earlier commit led to a memory leak in the untypical situation that zlib instances are created but never used, because zlib handles no longer started out their life as weak handles. The bug was introduced in bd20110. Refs: #20455 PR-URL: #21607 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An oversight in an earlier commit led to a memory leak
in the untypical situation that zlib instances are created
but never used, because zlib handles no longer started
out their life as weak handles.
The bug was introduced in bd20110.
Refs: #20455
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes