Uh oh!
There was an error while loading. Please reload this page.
doc: fix some typos in N-API docs - #21614
Conversation
This comment has been minimized.
This comment has been minimized.
vsemozhetbyt
commented
Jul 1, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
There was a problem hiding this comment.
It's restuls and not context in the source code (src/node_api.h and src/node_api.cc). Those should be updated to match as well?
There was a problem hiding this comment.
If so, please, anybody familiar with C++, push a commit in this PR or suggest a diff. I am afraid to break something)
There was a problem hiding this comment.
@vsemozhetbyt just keep result, it matches with the signature in src/node_api.h.
There was a problem hiding this comment.
Should I replace context with result then in options below so that the signature matches options?
vsemozhetbyt
commented
Jul 1, 2018
vsemozhetbyt
commented
Jul 1, 2018
Landed in 484c6c3 |
PR-URL: #21614 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #21614 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes