Skip to content

tools: lint doc code examples in strict mode - #21615

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:tools-eslint-doc-strict
Closed

tools: lint doc code examples in strict mode#21615
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:tools-eslint-doc-strict

Conversation

@vsemozhetbyt

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Refs: https://github.com/eslint/eslint-plugin-markdown#strict

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 1, 2018
@vsemozhetbytvsemozhetbyt added the doc Issues and PRs related to the documentations. label Jul 1, 2018
@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 1, 2018
@vsemozhetbyt

Copy link
Copy Markdown
ContributorAuthor

Landed in 0ef04b8
Thank you for the reviews.

@vsemozhetbyt
vsemozhetbyt deleted the tools-eslint-doc-strict branch July 6, 2018 05:46
vsemozhetbyt added a commit that referenced this pull request Jul 6, 2018
PR-URL: #21615
Refs: https://github.com/eslint/eslint-plugin-markdown#strict
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jul 6, 2018
PR-URL: #21615
Refs: https://github.com/eslint/eslint-plugin-markdown#strict
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targostargos mentioned this pull request Jul 17, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@vsemozhetbyt@nodejs-github-bot@addaleax@lpinca@cjihrig@hiroppy@JungMinu@trivikr