Skip to content

doc: fix heading level in errors.md - #21618

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-err-heading-level
Closed

doc: fix heading level in errors.md#21618
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-err-heading-level

Conversation

@vsemozhetbyt

@vsemozhetbytvsemozhetbyt commented Jul 1, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Current structure seems wrong:

err

@nodejs-github-bot

nodejs-github-bot commented Jul 1, 2018

Copy link
Copy Markdown
Collaborator

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/190/pipeline

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Jul 1, 2018
@vsemozhetbyt

vsemozhetbyt commented Jul 1, 2018

Copy link
Copy Markdown
ContributorAuthor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 1, 2018
@vsemozhetbytvsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 1, 2018
@vsemozhetbyt

vsemozhetbyt commented Jul 1, 2018

Copy link
Copy Markdown
ContributorAuthor

Landed in 6562942
Thank you for the reviews.

@vsemozhetbyt
vsemozhetbyt deleted the doc-err-heading-level branch July 1, 2018 21:49
vsemozhetbyt added a commit that referenced this pull request Jul 1, 2018
@vsemozhetbyt
doc: fix heading level in errors.md
6562942
PR-URL: #21618
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jul 3, 2018
@vsemozhetbyt@targos
doc: fix heading level in errors.md
cadc74d
PR-URL: #21618
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targostargos mentioned this pull request Jul 3, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.errorsIssues and PRs related to JavaScript errors originated in Node.js core.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vsemozhetbyt@nodejs-github-bot@lpinca@trivikr