Uh oh!
There was an error while loading. Please reload this page.
test: fix pummel/test-net-connect-memleak - #21658
Conversation
A loop that generates a long array is resulting in a RangeError. Moving to Array.prototype.fill() along with the ** operator instead of using a loop fixes the issue.
Trott
commented
Jul 4, 2018
Since pummel tests are not run in CI, a lite CI is likely sufficient for this. (It will lint the test at least.) |
addaleax
left a comment
There was a problem hiding this comment.
LGTM
The test could use a larger makeover and be moved to parallel, I think. With async_hooks, we now have a public API to make GC observable from userland, so we can avoid using a huge amount of memory just for that :)
Trott
commented
Jul 4, 2018
@addaleax I pondered seeing what would happen if I moved it to |
addaleax
commented
Jul 4, 2018
@Trott Yeah, sorry for being unclear – I’d only suggest moving out of (If you want, it’s totally fine to leave a |
Trott
commented
Jul 5, 2018
Trott
commented
Jul 6, 2018
Landed in ff958ad |
A loop that generates a long array is resulting in a RangeError. Moving to Array.prototype.fill() along with the ** operator instead of using a loop fixes the issue. PR-URL: nodejs#21658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
A loop that generates a long array is resulting in a RangeError. Moving to Array.prototype.fill() along with the ** operator instead of using a loop fixes the issue. PR-URL: #21658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
A loop that generates a long array is resulting in a RangeError. Moving to Array.prototype.fill() along with the ** operator instead of using a loop fixes the issue. PR-URL: #21658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
commented
Jul 13, 2018
The promised follow-up is in #21794 :) |
A loop that generates a long array is resulting in a RangeError. Moving
to Array.prototype.fill() along with the ** operator instead of using a
loop fixes the issue.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes