Skip to content

[v8.x-backport] n-api: throw when entry point is null - #21732

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:v8.x-stagingfrom
gabrielschulhof:backport-20779-to-v8.x
Closed

[v8.x-backport] n-api: throw when entry point is null#21732
gabrielschulhof wants to merge 1 commit into
nodejs:v8.x-stagingfrom
gabrielschulhof:backport-20779-to-v8.x

Conversation

@gabrielschulhof

@gabrielschulhofgabrielschulhof commented Jul 10, 2018

Copy link
Copy Markdown
Contributor

PR-URL: #20779

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jul 10, 2018

Copy link
Copy Markdown
Collaborator

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/239/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Jul 10, 2018
@gabrielschulhof

gabrielschulhof commented Jul 10, 2018

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/15777/

@gabrielschulhof

gabrielschulhof commented Jul 10, 2018

Copy link
Copy Markdown
ContributorAuthor

Resumed as: https://ci.nodejs.org/job/node-test-pull-request/15780/

@gabrielschulhof

gabrielschulhof commented Jul 10, 2018

Copy link
Copy Markdown
ContributorAuthor

Resume Build doesn't seem to work for node-test-commit-windows-fanned.

@MylesBorins

MylesBorins commented Jul 13, 2018

Copy link
Copy Markdown
Contributor

@gabrielschulhof can you please rebase against v8.x-staging

Gabriel Schulhof
n-api: throw when entry point is null
d4e5de2
PR-URL: nodejs#20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gabrielschulhof

gabrielschulhof commented Jul 14, 2018

Copy link
Copy Markdown
ContributorAuthor

@MylesBorins done.

@MylesBorins

MylesBorins commented Jul 31, 2018

Copy link
Copy Markdown
Contributor

one more ci: https://ci.nodejs.org/job/node-test-pull-request/16099/

MylesBorins pushed a commit that referenced this pull request Aug 1, 2018
Gabriel Schulhof@MylesBorins
n-api: throw when entry point is null
b48791d
Backport-PR-URL: #21732
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins

MylesBorins commented Aug 1, 2018

Copy link
Copy Markdown
Contributor

Failures are known flakes

b48791d

@gabrielschulhofgabrielschulhof mentioned this pull request Aug 8, 2018
Closed
rvagg pushed a commit that referenced this pull request Aug 16, 2018
Gabriel Schulhof@rvagg
n-api: throw when entry point is null
7033bba
Backport-PR-URL: #21732
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gabrielschulhof
gabrielschulhof deleted the backport-20779-to-v8.x branch June 14, 2019 23:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gabrielschulhof@nodejs-github-bot@MylesBorins@Trott