Skip to content

stream: name anonymous function in _stream_writable.js - #21753

Closed
mariotsi wants to merge 1 commit into
nodejs:masterfrom
mariotsi:anonymous-functions
Closed

stream: name anonymous function in _stream_writable.js#21753
mariotsi wants to merge 1 commit into
nodejs:masterfrom
mariotsi:anonymous-functions

Conversation

@mariotsi

@mariotsimariotsi commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Refs: #8913

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Jul 11, 2018
@trivikr

trivikr commented Jul 11, 2018

Copy link
Copy Markdown
Member

Thank you @mariotsi for raising your first PR in Node.js core! 🎉

CI: https://ci.nodejs.org/job/node-test-pull-request/15798/

lpinca
lpinca approved these changes Jul 12, 2018
View reviewed changes
Comment threadlib/_stream_writable.js Outdated

@lpincalpincaJul 12, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, the name is inferred from the variable name.

@mariotsimariotsiJul 12, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed

@mariotsi
mariotsiforce-pushed the anonymous-functions branch 2 times, most recently from 6022077 to 99f0f13CompareJuly 12, 2018 09:58
@mariotsi
mariotsiforce-pushed the anonymous-functions branch from 99f0f13 to 6e836afCompareJuly 12, 2018 10:01
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 12, 2018
@mariotsi

mariotsi commented Jul 12, 2018

Copy link
Copy Markdown
ContributorAuthor

@BridgeAR just checking the meaning of the "author ready" and I'm wondering what LG stands for

@trivikr

trivikr commented Jul 13, 2018

Copy link
Copy Markdown
Member

author-ready label is used for PRs that can land (details)
LG is "Looks good" I think (reviewing wiki)

maclover7
maclover7 approved these changes Jul 13, 2018
View reviewed changes

@maclover7maclover7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: https://ci.nodejs.org/job/node-test-pull-request/15858/

@mariotsi

mariotsi commented Jul 16, 2018

Copy link
Copy Markdown
ContributorAuthor

@maclover7 one task if the CI is running from two days.

@Trott

Trott commented Jul 16, 2018

Copy link
Copy Markdown
Member

Linter only needs a re-run. I'm unable to restart it right now for some reason.

@trivikr

trivikr commented Jul 18, 2018

Copy link
Copy Markdown
Member

node-test-linter re-run https://ci.nodejs.org/job/node-test-linter/20693/

@BridgeAR

BridgeAR commented Jul 18, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Linter CI https://ci.nodejs.org/job/node-test-linter/20702/ ✔️

[edit] I should refresh next time ;-) [/edit]

@mariotsi

mariotsi commented Jul 18, 2018

Copy link
Copy Markdown
ContributorAuthor

I still see node-test-commit running from 3 days

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jul 18, 2018
@mariotsi@BridgeAR
stream: name anonymous function in _stream_writable.js
caf2335
PR-URL: nodejs#21753
Refs: nodejs#8913
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR

BridgeAR commented Jul 18, 2018

Copy link
Copy Markdown
Member

Landed in caf2335 🎉

@mariotsi congratulations on your first commit to Node.js! :-) The CI did not detect the rerun of the linter. But all checks passed.

targos pushed a commit that referenced this pull request Jul 19, 2018
@mariotsi@targos
stream: name anonymous function in _stream_writable.js
6af4f1f
PR-URL: #21753
Refs: #8913
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mariotsi
mariotsi deleted the anonymous-functions branch July 19, 2018 09:34
@mariotsi

mariotsi commented Jul 19, 2018

Copy link
Copy Markdown
ContributorAuthor

Thanks :) See you on the next PR!

@targostargos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 19, 2018
@targostargos mentioned this pull request Jul 31, 2018
Merged
@beevelopbeevelop mentioned this pull request Aug 1, 2018
Closed
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
@snyk-botsnyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@maclover7maclover7maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@mariotsi@trivikr@Trott@BridgeAR@jasnell@addaleax@lpinca@cjihrig@maclover7@targos@nodejs-github-bot