Skip to content

tls: name anonymous function in tls.js - #21754

Closed
klacabane wants to merge 1 commit into
nodejs:masterfrom
klacabane:name-anonymous-function-dev
Closed

tls: name anonymous function in tls.js#21754
klacabane wants to merge 1 commit into
nodejs:masterfrom
klacabane:name-anonymous-function-dev

Conversation

@klacabane

@klacabaneklacabane commented Jul 11, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #8913

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Jul 11, 2018
@trivikr

trivikr commented Jul 11, 2018

Copy link
Copy Markdown
Member

Thank you @klacabane for your first PR in Node.js core! 🎉

CI: https://ci.nodejs.org/job/node-test-pull-request/15799/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 12, 2018
@trivikr

trivikr commented Jul 14, 2018

Copy link
Copy Markdown
Member

node-test-commit-linux re-run https://ci.nodejs.org/job/node-test-commit-linux/20101/

@trivikr

trivikr commented Jul 18, 2018

Copy link
Copy Markdown
Member

Landed in 07c514c

Congratulations @klacabane on your first commit in Node.js core! 🎉🎉🎉

@trivikrtrivikr closed this Jul 18, 2018
trivikr pushed a commit that referenced this pull request Jul 18, 2018
@klacabane@trivikr
tls: name anonymous function in tls.js
07c514c
Refs: #8913
PR-URL: #21754
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos pushed a commit that referenced this pull request Jul 19, 2018
@klacabane@targos
tls: name anonymous function in tls.js
0f70017
Refs: #8913
PR-URL: #21754
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@targostargos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@maclover7maclover7maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@klacabane@trivikr@jasnell@lpinca@maclover7@BridgeAR@nodejs-github-bot