Skip to content

named anonymous functions in readline & zlib.js - #21792

Closed
antsmartian wants to merge 1 commit into
nodejs:masterfrom
antsmartian:anonymous_functions
Closed

named anonymous functions in readline & zlib.js#21792
antsmartian wants to merge 1 commit into
nodejs:masterfrom
antsmartian:anonymous_functions

Conversation

@antsmartian

@antsmartianantsmartian commented Jul 13, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added readline Issues and PRs related to the built-in readline module. zlib Issues and PRs related to the zlib subsystem. labels Jul 13, 2018
apapirovski
apapirovski reviewed Jul 13, 2018
View reviewed changes

@apapirovskiapapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @antsmartian, the goal of naming these functions should be to make a more useful name than the anonymous one. Please try to consider the use cases for these functions and name based on that. In particular this applies to fnWrap.

@antsmartian

antsmartian commented Jul 13, 2018

Copy link
Copy Markdown
ContributorAuthor

Yeah sure. Will do the same and update.

@antsmartian

antsmartian commented Jul 13, 2018

Copy link
Copy Markdown
ContributorAuthor

@apapirovski Ok, I did skimmed the source code of zlip.js, looks like we can use syncBufferWrapper, as this function just returns the zlibBufferSync and used for different compression formats like gzip, gunzip etc in sync mode. Similary, for zlibBuffer, we can name it as asyncBufferWrapper as the implementation of zlibBuffer is based on event emitters (async). Let me know if I'm wrong otherwise here.

For SIGCONT, I better rename the function to be continueProcess, as I guess that suits more natural. Thanks.

apapirovski
apapirovski approved these changes Jul 15, 2018
View reviewed changes
Comment threadlib/readline.js Outdated

@apapirovskiapapirovskiJul 15, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we could actually do a slightly better thing here. Instead of the IIFE, we could use an arrow function and replace self with this — unless I'm missing something. Then we will just have a normal event callback instead of this weird thing it is right now. Feel free to either do that change here or in a separate PR.

@antsmartianantsmartianJul 16, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that make sense, may be will update the same in another PR. Thanks for your time on this.

@trivikr

trivikr commented Jul 16, 2018

Copy link
Copy Markdown
Member

Thank you @antsmartian for your first PR in Node.js core!

The user.email needs to be updated in the commit as specified in this step
The current user.email is not registered with Github

@antsmartian

antsmartian commented Jul 16, 2018

Copy link
Copy Markdown
ContributorAuthor

@trivikr Thanks, for some reason, my git config wasn't correct. Now fixed.

@trivikr

trivikr commented Jul 18, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/15928/

@apapirovski

apapirovski commented Jul 29, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/16061/

@apapirovskiapapirovski added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 29, 2018
@maclover7

maclover7 commented Jul 30, 2018

Copy link
Copy Markdown
Contributor

Resumed CI: https://ci.nodejs.org/job/node-test-pull-request/16082/

@maclover7

maclover7 commented Aug 2, 2018

Copy link
Copy Markdown
Contributor

Resumed once again, infrastructure issue on OSX: https://ci.nodejs.org/job/node-test-pull-request/16141/

@trivikr

trivikr commented Aug 2, 2018

Copy link
Copy Markdown
Member

Landed in fc6f49a

@trivikrtrivikr closed this Aug 2, 2018
trivikr pushed a commit that referenced this pull request Aug 2, 2018
@antsmartian@trivikr
readline,zlib: named anonymous functions
fc6f49a
PR-URL: #21792
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos pushed a commit that referenced this pull request Aug 2, 2018
@antsmartian@targos
readline,zlib: named anonymous functions
76a6592
PR-URL: #21792
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@antsmartian
antsmartian deleted the anonymous_functions branch August 4, 2018 08:39
@rvaggrvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@trivikrtrivikrtrivikr approved these changes
+3 more reviewers
@apapirovskiapapirovskiapapirovski approved these changes
@maclover7maclover7maclover7 approved these changes
@hiroppyhiroppyhiroppy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.readlineIssues and PRs related to the built-in readline module.zlibIssues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@antsmartian@trivikr@apapirovski@maclover7@jasnell@cjihrig@hiroppy@nodejs-github-bot