Uh oh!
There was an error while loading. Please reload this page.
test: fix n-api addon build warnings - #21808
Closed
kfarnung wants to merge 1 commit into
Closed
Conversation
richardlau
commented
Jul 14, 2018
Member
Looks like the |
kfarnung
commented
Jul 16, 2018
ContributorAuthor
Duplicate of#21796 |
kfarnung
commented
Jul 16, 2018
ContributorAuthor
I'll let #21796 land and rebase on those changes, the remaining one is purely to quiet a warning in MSVC. |
Fixed an MSVC warning on Windows: * test_general.c - Lossy conversion from int64 to double, explicitly casting to double resolved the warning
addaleax
approved these changes
Jul 18, 2018
addaleax
commented
Jul 18, 2018
Member
jasnell
approved these changes
Jul 18, 2018
cjihrig
approved these changes
Jul 19, 2018
maclover7
commented
Jul 30, 2018
Contributor
trivikr
commented
Aug 3, 2018
Member
maclover7
commented
Aug 4, 2018
Contributor
Landed in f8d34b9 |
maclover7 pushed a commit
that referenced
this pull request
Aug 4, 2018
Fixed an MSVC warning on Windows: * test_general.c - Lossy conversion from int64 to double, explicitly casting to double resolved the warning PR-URL: #21808 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit
that referenced
this pull request
Aug 6, 2018
Fixed an MSVC warning on Windows: * test_general.c - Lossy conversion from int64 to double, explicitly casting to double resolved the warning PR-URL: #21808 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an MSVC warning on Windows:
casting to double resolved the warning
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes