Uh oh!
There was an error while loading. Please reload this page.
doc: fix vm.runInNewContext signature - #21824
Closed
targos wants to merge 1 commit into
Closed
Conversation
The `options` parameter cannot be passed without `sandbox`.
targos
commented
Jul 15, 2018
MemberAuthor
Please 👍 this comment to fast-track. |
vsemozhetbyt
approved these changes
Jul 15, 2018
TimothyGu
approved these changes
Jul 15, 2018
lpinca
approved these changes
Jul 15, 2018
addaleax
approved these changes
Jul 15, 2018
addaleax
commented
Jul 15, 2018
Member
Landed in d279a8f |
addaleax pushed a commit
that referenced
this pull request
Jul 15, 2018
The `options` parameter cannot be passed without `sandbox`. PR-URL: #21824 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit
that referenced
this pull request
Jul 16, 2018
The `options` parameter cannot be passed without `sandbox`. PR-URL: #21824 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
optionsparameter cannot be passed withoutsandbox.Checklist