Skip to content

test: remove timeout from test-pipe-stream - #21837

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:test-pipe-stream-no-timeout
Closed

test: remove timeout from test-pipe-stream#21837
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:test-pipe-stream-no-timeout

Conversation

@addaleax

@addaleaxaddaleax commented Jul 16, 2018

Copy link
Copy Markdown
Member

The timeout is unnecessary and the suspected cause of the following
failure (even though I could not reproduce it locally):

11:53:54 not ok 197 parallel/test-pipe-stream
11:53:54 ---
11:53:54 duration_ms: 6.253
11:53:54 severity: fail
11:53:54 exitcode: 1
11:53:54 stack: |-
11:53:54 assert.js:338
11:53:54 throw err;
11:53:54 ^
11:53:54
11:53:54 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
11:53:54
11:53:54 assert.ok(have_ping)
11:53:54
11:53:54 at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12)
11:53:54 at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5)
11:53:54 at Server.emit (events.js:182:13)
11:53:54 at emitCloseNT (net.js:1668:8)
11:53:54 at process._tickCallback (internal/process/next_tick.js:63:19)

(From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: remove timeout from test-pipe-stream
c37c013
The timeout is unnecessary and the suspected cause of the following
failure (even though I could not reproduce it locally):
11:53:54 not ok 197 parallel/test-pipe-stream
11:53:54 ---
11:53:54 duration_ms: 6.253
11:53:54 severity: fail
11:53:54 exitcode: 1
11:53:54 stack: |-
11:53:54 assert.js:338
11:53:54 throw err;
11:53:54 ^
11:53:54
11:53:54 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
11:53:54
11:53:54 assert.ok(have_ping)
11:53:54
11:53:54 at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12)
11:53:54 at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5)
11:53:54 at Server.emit (events.js:182:13)
11:53:54 at emitCloseNT (net.js:1668:8)
11:53:54 at process._tickCallback (internal/process/next_tick.js:63:19)
(From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.)
@nodejs-github-bot

nodejs-github-bot commented Jul 16, 2018

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/286/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2018
@Trott

Trott commented Jul 16, 2018

Copy link
Copy Markdown
Member

@addaleax (or anyone else curious, in case @addaleax already knows this): I'm able to reproduce locally by reducing the timeout to 200 rather than 2000 and running a bunch of tests simultaneously. Or you can go the really easy route and reduce the timeout to 1.

@addaleaxaddaleax added net Issues and PRs related to the net subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jul 17, 2018
@addaleax

addaleax commented Jul 18, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/15932/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 18, 2018
@addaleax

addaleax commented Jul 19, 2018

Copy link
Copy Markdown
MemberAuthor

ARM re-build: https://ci.nodejs.org/job/node-test-commit-arm-fanned/2404/

@addaleax

addaleax commented Jul 26, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 36a15a1

@addaleax
addaleax deleted the test-pipe-stream-no-timeout branch July 26, 2018 11:59
addaleax added a commit that referenced this pull request Jul 26, 2018
@addaleax
test: remove timeout from test-pipe-stream
36a15a1
The timeout is unnecessary and the suspected cause of the following
failure (even though I could not reproduce it locally):
11:53:54 not ok 197 parallel/test-pipe-stream
11:53:54 ---
11:53:54 duration_ms: 6.253
11:53:54 severity: fail
11:53:54 exitcode: 1
11:53:54 stack: |-
11:53:54 assert.js:338
11:53:54 throw err;
11:53:54 ^
11:53:54
11:53:54 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
11:53:54
11:53:54 assert.ok(have_ping)
11:53:54
11:53:54 at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12)
11:53:54 at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5)
11:53:54 at Server.emit (events.js:182:13)
11:53:54 at emitCloseNT (net.js:1668:8)
11:53:54 at process._tickCallback (internal/process/next_tick.js:63:19)
(From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.)
PR-URL: #21837
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 26, 2018
@addaleax@targos
test: remove timeout from test-pipe-stream
4958501
The timeout is unnecessary and the suspected cause of the following
failure (even though I could not reproduce it locally):
11:53:54 not ok 197 parallel/test-pipe-stream
11:53:54 ---
11:53:54 duration_ms: 6.253
11:53:54 severity: fail
11:53:54 exitcode: 1
11:53:54 stack: |-
11:53:54 assert.js:338
11:53:54 throw err;
11:53:54 ^
11:53:54
11:53:54 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
11:53:54
11:53:54 assert.ok(have_ping)
11:53:54
11:53:54 at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12)
11:53:54 at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5)
11:53:54 at Server.emit (events.js:182:13)
11:53:54 at emitCloseNT (net.js:1668:8)
11:53:54 at process._tickCallback (internal/process/next_tick.js:63:19)
(From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.)
PR-URL: #21837
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.flaky-testIssues and PRs related to the tests with unstable failures on the CI.netIssues and PRs related to the net subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@nodejs-github-bot@Trott@jasnell@lpinca@cjihrig