Uh oh!
There was an error while loading. Please reload this page.
src: fix formatting of PIDs - #21852
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
jasnell
approved these changes
Jul 17, 2018
trivikr
approved these changes
Jul 18, 2018
joyeecheung
approved these changes
Jul 18, 2018
lpinca
approved these changes
Jul 18, 2018
maclover7
approved these changes
Jul 20, 2018
maclover7
commented
Jul 20, 2018
Contributor
tniessen added a commit
that referenced
this pull request
Jul 22, 2018
PR-URL: #21852 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
tniessen
commented
Jul 22, 2018
MemberAuthor
Landed in 8ac9163. |
targos pushed a commit
that referenced
this pull request
Jul 24, 2018
PR-URL: #21852 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
This was referenced Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv_pid_tseems to be signed on all supported platforms, so%dseems appropriate.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes