Skip to content

[v10.x] http: allow url and options to be passed to http*.request and http*.get - #21880

Closed
targos wants to merge 2 commits into
nodejs:v10.x-stagingfrom
targos:backport-21616
Closed

[v10.x] http: allow url and options to be passed to http*.request and http*.get#21880
targos wants to merge 2 commits into
nodejs:v10.x-stagingfrom
targos:backport-21616

Conversation

@targos

@targostargos commented Jul 19, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Backport of #21616

@nodejs-github-bot

nodejs-github-bot commented Jul 19, 2018

Copy link
Copy Markdown
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/313/pipeline

@targos

targos commented Jul 19, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/15943/
Edit: resumed build: https://ci.nodejs.org/job/node-test-pull-request/15947/

@targos

targos commented Jul 20, 2018

Copy link
Copy Markdown
MemberAuthor

@nodejs/http

@targos

targos commented Jul 24, 2018

Copy link
Copy Markdown
MemberAuthor

Ping

@trivikr

trivikr commented Jul 27, 2018

Copy link
Copy Markdown
Member

\cc @rubys

rubys added 2 commits August 2, 2018 21:58
@rubys@targos
http: allow url and options to be passed to http*.request and http*.get
4436efc
Fixes: nodejs#20795
PR-URL: nodejs#21616
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@rubys@targos
https: allow url and options to be passed to https.request
0c748a4
PR-URL: nodejs#22003
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos

targos commented Aug 2, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Rebased and added #22003. PTAL.
CI: https://ci.nodejs.org/job/node-test-pull-request/16158/
Edit: rebuild https://ci.nodejs.org/job/node-test-commit-linuxone/3528/

@targostargos added http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. labels Aug 2, 2018
@targos

targos commented Aug 4, 2018

Copy link
Copy Markdown
MemberAuthor

Ping @trivikr since I added a new commit.
Ping @rubys this backports two of your PRs.

@targos

targos commented Aug 6, 2018

Copy link
Copy Markdown
MemberAuthor

Summoning @nodejs/collaborators. I'm desperately waiting for reviews :)

@targostargos added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 6, 2018
Trott
Trott approved these changes Aug 6, 2018
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

mcollina
mcollina approved these changes Aug 6, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

targos pushed a commit that referenced this pull request Aug 7, 2018
@rubys@targos
http: allow url and options to be passed to http*.request and http*.get
37369eb
Fixes: #20795
PR-URL: #21616
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Backport-PR-URL: #21880
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Aug 7, 2018
@rubys@targos
https: allow url and options to be passed to https.request
2bf9a4a
PR-URL: #22003
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: #21880
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos

targos commented Aug 7, 2018

Copy link
Copy Markdown
MemberAuthor

Thank you! Landed in 37369eb and 2bf9a4a

@targostargos closed this Aug 7, 2018
@targos
targos deleted the backport-21616 branch August 7, 2018 06:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@TrottTrottTrott approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.httpsIssues or PRs related to the https subsystem.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@targos@nodejs-github-bot@trivikr@mcollina@Trott@rubys