Uh oh!
There was an error while loading. Please reload this page.
doc : Fix incorrect method name - #21908
Closed
antsmartian wants to merge 1 commit into
Closed
Conversation
cjihrig
approved these changes
Jul 20, 2018
vsemozhetbyt
approved these changes
Jul 20, 2018
vsemozhetbyt
commented
Jul 20, 2018
Contributor
vsemozhetbyt
commented
Jul 20, 2018
Contributor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
lance
approved these changes
Jul 20, 2018
jasnell
approved these changes
Jul 20, 2018
vsemozhetbyt pushed a commit
that referenced
this pull request
Jul 20, 2018
PR-URL: #21908 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
vsemozhetbyt
commented
Jul 20, 2018
Contributor
Landed in 79e63c5 |
ContributorAuthor
Wow, that's so quick. Thanks everyone, cc @vsemozhetbyt . |
4 tasks
targos pushed a commit
that referenced
this pull request
Jul 20, 2018
PR-URL: #21908 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#21904
make -j4 test(UNIX), orvcbuild test(Windows) passes