Skip to content

doc: add node-test-commit-custom-suites to docs - #21927

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:internet-tests
Closed

doc: add node-test-commit-custom-suites to docs#21927
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:internet-tests

Conversation

@Trott

Copy link
Copy Markdown
Member

Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: #21909 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

/ping @lance@maclover7

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@vsemozhetbytvsemozhetbyt added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. meta Issues and PRs related to the general management of the project. labels Jul 21, 2018

@lancelance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott thanks!

Comment threadCOLLABORATOR_GUIDE.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is true that the default CI_JS_SUITES parameters to the job run internet the job is intended to run any test(suite) with custom arguments (I think you could even simulate the stress job by passing --repeat to TEST_ARGS).

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to provide the minimum information to be useful. (I'd like to see pummel added FWIW.) If you have some alternate or additional text, do feel free to add it!

Comment threadCOLLABORATOR_GUIDE.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly... how about:

node-test-commit-custom-suites runs tests in user-specified directories with parameters provided by the user as well. Currently used on all node-test-commit jobs to run the default test suite with the --worker flag.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maclover7 Updated. PTAL

Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.
Refs: nodejs#21909 (comment)

@maclover7maclover7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Trott

Copy link
Copy Markdown
MemberAuthor

Trott added a commit to Trott/io.js that referenced this pull request Jul 24, 2018
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.
Refs: nodejs#21909 (comment)
PR-URL: nodejs#21927
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

Copy link
Copy Markdown
MemberAuthor

Landed in f5a2167

@TrottTrott closed this Jul 24, 2018
targos pushed a commit that referenced this pull request Jul 26, 2018
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.
Refs: #21909 (comment)
PR-URL: #21927
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targostargos mentioned this pull request Jul 31, 2018
@Trott
Trott deleted the internet-tests branch January 13, 2022 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@nodejs-github-bot@lance@maclover7@richardlau@trivikr@vsemozhetbyt