Uh oh!
There was an error while loading. Please reload this page.
Closed
Conversation
BridgeAR
approved these changes
Jul 25, 2018
BridgeAR
commented
Jul 25, 2018
Member
This should land before #21964. Otherwise this change should be included directly in the mentioned PR. |
silverwind
commented
Jul 25, 2018
Contributor
#21964 is now a superset of this PR. I'd say we close this one. |
ghost
commented
Jul 26, 2018
Author
Since #21964 has added benchmark tests, so this is duplicated and close this. |
ghost
deleted the
BufferSupportUSC2
branch
July 26, 2018 01:16
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #21963
make -j4 test(UNIX), orvcbuild test(Windows) passes