Skip to content

doc: do not advise to cancel full CI on onboarding - #21977

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-no-ci-aborting
Closed

doc: do not advise to cancel full CI on onboarding#21977
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-no-ci-aborting

Conversation

@vsemozhetbyt

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Refs: #21938 (comment) and discussion below the comment.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 25, 2018
@vsemozhetbytvsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Jul 25, 2018
@vsemozhetbyt

Copy link
Copy Markdown
ContributorAuthor

Should we cc and label TSC for this?

@vsemozhetbytvsemozhetbyt mentioned this pull request Jul 25, 2018
3 tasks
@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 25, 2018
@maclover7

Copy link
Copy Markdown
Contributor

cc @Trott

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 26, 2018
@Trott

Copy link
Copy Markdown
Member

👍 this comment to fast-track.

@vsemozhetbyt

Copy link
Copy Markdown
ContributorAuthor

Landed in a9f32a3
Thank you for the reviews.

@vsemozhetbyt
vsemozhetbyt deleted the doc-no-ci-aborting branch July 26, 2018 15:02
vsemozhetbyt added a commit that referenced this pull request Jul 26, 2018
Refs: #21938 (comment)
and discussion below the comment.
PR-URL: #21977
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos pushed a commit that referenced this pull request Jul 26, 2018
Refs: #21938 (comment)
and discussion below the comment.
PR-URL: #21977
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@targostargos mentioned this pull request Jul 31, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@vsemozhetbyt@nodejs-github-bot@maclover7@Trott@apapirovski@refack@joaocgreis@mmarchini@richardlau