Uh oh!
There was an error while loading. Please reload this page.
test: remove test/gc, integrate into parallel - #22001
Closed
addaleax wants to merge 2 commits into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
There’s no reason to have a separate addon just for testing GC anymore.
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/16027/ (edit: ✔️) |
jasnell
approved these changes
Jul 27, 2018
refack
approved these changes
Jul 27, 2018
refack
left a comment
Contributor
There was a problem hiding this comment.
🕺
Removing obsolete code is my favorite kind of change
cjihrig
approved these changes
Jul 27, 2018
maclover7
approved these changes
Jul 27, 2018
maclover7
commented
Jul 27, 2018
Contributor
Can you remove the |
addaleax
commented
Jul 27, 2018
MemberAuthor
@maclover7 Done :) |
benjamingr
approved these changes
Jul 27, 2018
richardlau
approved these changes
Jul 27, 2018
BridgeAR
approved these changes
Jul 29, 2018
maclover7
commented
Jul 29, 2018
Contributor
addaleax
commented
Jul 31, 2018
MemberAuthor
trivikr
approved these changes
Aug 1, 2018
addaleax
commented
Aug 1, 2018
MemberAuthor
Landed in 02badc4 |
addaleax added a commit
that referenced
this pull request
Aug 1, 2018
There’s no reason to have a separate addon just for testing GC anymore. PR-URL: #22001 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
Aug 1, 2018
There’s no reason to have a separate addon just for testing GC anymore. PR-URL: #22001 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There’s no reason to have a separate addon just for
testing GC anymore.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @nodejs/build-files @nodejs/testing